From owner-freebsd-stable@FreeBSD.ORG Mon Apr 26 08:12:36 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19A321065672 for ; Mon, 26 Apr 2010 08:12:36 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp114.plus.mail.re1.yahoo.com (smtp114.plus.mail.re1.yahoo.com [69.147.102.77]) by mx1.freebsd.org (Postfix) with SMTP id B24538FC15 for ; Mon, 26 Apr 2010 08:12:35 +0000 (UTC) Received: (qmail 7165 invoked from network); 26 Apr 2010 08:12:35 -0000 Received: from [10.141.21.121] (se@80.187.149.48 with plain) by smtp114.plus.mail.re1.yahoo.com with SMTP; 26 Apr 2010 01:12:31 -0700 PDT X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. X-YMail-OSG: 4Z4wvW4VM1lFZcjXn.XL7cmr76RUFvNUuBbNFIu1iQ_Gd00 St19zCC46XnkOerZcd87PRuh0IiRy2SJg5G._DiiCNvvJMHpGIAkGS4v9x2T Gcl2Q1urv366CBmpMT3Mn4ZKRd_Z4aiQuTM68tBbFImdIhpttqpc2JLFJVpB 6tULHjIGwyv1rZdylgZjL.xkW0mRsiXaW3EQ4x6RMkFBbBA0HzMFLFfWLBIP Z7JgnKzNBVCpVCfgkmM8euySiMNzmf.NCXzwaEMFN31.hqFp_ewT6Z3cdpQ_ ac6hvaj0G96yDVNDZAWsGIIjXwhk9n1KP9lPNpah7VFaWTzCEUXiMDQK_Brv bRy_ct7hRwAGwNyqfm5uN.39a95HrV6o- X-Yahoo-Newman-Property: ymail-3 Message-ID: <4BD54AC7.7090301@FreeBSD.org> Date: Mon, 26 Apr 2010 10:11:51 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 ThunderBrowse/3.2.2.1 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Marin Atanasov References: <4B28F841.1070900@skylinetele.com> In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: "Li, Qing" , freebsd-stable@freebsd.org, "Prokofiev S.P." , freebsd-net@freebsd.org, Qing Li , freebsd-current@freebsd.org Subject: Re: net/mpd5, ppp, proxy-arp issues X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 08:12:36 -0000 Am 22.04.2010 20:43, schrieb Marin Atanasov: > Hello, > > Thanks a lot for the patch, Qing! > > It works fine. However I've noticed one thing, after I start mpd5 and > connect to my home network: > > kernel: WARNING: attempt to domain_add(netgraph) after domainfinalize() > > Not very sure if this is something to worry about or not? There was a problem with the initialization order of network "domains", which caused kernel crashes with ISDN+INET6 some two years ago. The reason was, that there was an implicit assumption, that all domains were initialized when the network interfaces are initialized, with NULL dereferences if domains are added (and relevant to a device) after the device has been initialized. I debugged this problem and prepared a patch for discussion, which later was committed by Max Laier (if memory serves me right). The message was added in order to identify further situations, where network domains are added after network interfaces have been initialized. This message ought to be informational right now, since the interface init is repeated whenever a network domain is added as part of above mentioned patch. Init order should be fixed, if this message is printed for compiled in drivers, but in case of a kernel module (like netgraph) that adds a domain, it is unadvoidable that the init order is reversed. Perhaps the message should be made conditional on the start-up of the kernel not having finished, or it should be completely removed, since time has shown, that the init order is correct in general. I'll remove that message (or make it conditional on "bootverbose") unless there is opposition to this change ... Regards, STefan