From owner-freebsd-stable@freebsd.org Wed Dec 14 09:31:35 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74F06C76220 for ; Wed, 14 Dec 2016 09:31:35 +0000 (UTC) (envelope-from herbert@mailbox.org) Received: from mx2.mailbox.org (mx2.mailbox.org [80.241.60.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.mailbox.org", Issuer "SwissSign Server Silver CA 2014 - G22" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 354001DB1; Wed, 14 Dec 2016 09:31:34 +0000 (UTC) (envelope-from herbert@mailbox.org) Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 83F4F43865; Wed, 14 Dec 2016 10:31:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= content-transfer-encoding:content-type:content-type:mime-version :references:in-reply-to:subject:subject:from:from:message-id :date:date:received; s=mail20150812; t=1481707884; bh=IGn4gBZOVQ BhLrwQ2PizAxgQIZQ3k3n1qpWeaI9de0M=; b=ngY9wuG7EoTPr+RvP6EI07jYm9 S76OvRkpCtkbTIzIiFUpSXLmVRAoYYRuERfv11m7IsQDEWhEFKm7CEox9sIgpbEt v4zf0XYdxOEoWcjLszK52DBfTxwL484+/qeGvtNZfsEvwFjW4mkxIkSkAo2Amhh1 36J6fC5u+OnkJPbHcVj1JF+IKLkj8ut1YcSIau4bHE6zFV89aappyo6arwyyv6AE 9g4XR51FHaIWrVDs7umAoEfeEIHBmIC7fZBQM2U9FggB2GRzfC0LRaNDJfiApOSV 0Wr5B5PvJnwIpFUnwcShMHoE6LXrwdtUSl7GrmeBLWNgrX4EgGDjg115earA== X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id KVNlcHppVtek; Wed, 14 Dec 2016 10:31:24 +0100 (CET) Date: Wed, 14 Dec 2016 10:31:22 +0100 Message-ID: <86fulquaad.wl-herbert@mailbox.org> From: "Herbert J. Skuhra" To: Ian Lepore Cc: tech-lists , freebsd-stable@freebsd.org Subject: Re: make buildkernel does not respect KERNCONF or JOBS in /etc/make.conf In-Reply-To: <1481649408.1889.338.camel@freebsd.org> References: <127a9164-9ad2-47c4-9ec4-e9f59cbe94f2@zyxst.net> <8637hu76pm.wl-herbert@mailbox.org> <86shpspvgx.wl-herbert@mailbox.org> <8f66557b-cf51-f140-eb49-03e806fb73ca@zyxst.net> <1481649233.1889.337.camel@freebsd.org> <1481649408.1889.338.camel@freebsd.org> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 09:31:35 -0000 Ian Lepore skrev: > = > On Tue, 2016-12-13 at 10:13 -0700, Ian Lepore wrote: >> On Tue, 2016-12-13 at 10:00 +0000, tech-lists wrote: >> > = >> > On 12/12/2016 23:40, Herbert J. Skuhra wrote: >> > > = >> > > = >> > > PORTS_MODULES does not work if KERNCONF contains multiple >> > > kernels: >> > > = >> > > The problem is obviously in /usr/src/sys/conf/kern.post.mk (line= >> > > 66): >> > > = >> > > WRKDIRPREFIX?=3D=A0=A0${MAKEOBJDIRPREFIX}${SRC_BASE}/sys/${KERNC= ONF} >> > hmm! I didn't know that. >> > = >> > I can't confirm exactly when the old way stopped working and when >> > I=A0 >> > started defining modules in src.conf. >> > = >> > If I wanted to install a known, good kernel as /boot/workingkernel= >> > with=A0 >> > all of its modules, so that I can avoid kernel.old being a bad >> > kernel=A0 >> > and kernel being non-bootable, how would I go about doing it? >> > = >> > many thanks, >> > = >> I think the problem might have started with some changes to the >> kernel >> build infrastructure that result in reading make.conf and/or src.con= f >> when they didn't used to, so now KERNCONF with multiple entries is >> defined differently in kern.post.mk than it used to be. >> = >> I wonder if this patch might fix it (I'm not in a position to test i= t >> myself right now -- this is purely a shot in the dark)... >> = >> iIndex: sys/conf/kern.post.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/conf/kern.post.mk (revision 302505) >> +++ sys/conf/kern.post.mk (working copy) >> @@ -63,7 +63,7 @@ OSRELDATE!=3D awk >> '/^\#define[[:space:]]*__FreeBSD_v >> =A0 =A0=A0=A0=A0${MAKEOBJDIRPREFIX}${SRC_BASE}/include/osreldate >> .h >> =A0.endif >> =A0# Keep the related ports builds in the obj directory so that they= >> are only rebuilt once per kernel build >> -WRKDIRPREFIX?=3D ${MAKEOBJDIRPREFIX}${SRC_BASE}/sys/${KERNCONF} >> +WRKDIRPREFIX?=3D ${MAKEOBJDIRPREFIX}${SRC_BASE}/sys/${.OBJDIR} >> =A0PORTSMODULESENV=3D\ >> =A0 PATH=3D${PATH}:${LOCALBASE}/bin:${LOCALBASE}/sbin \ >> =A0 SRC_BASE=3D${SRC_BASE} \ >> = >> -- Ian > = > Actually, now that I look at it again, I wonder if it should be just:= > = > +WRKDIRPREFIX?=3D ${.OBJDIR} Yeah, this could work: Before: =3D=3D=3D> Ports module x11/nvidia-driver (all) cd ${PORTSDIR:-/usr/ports}/x11/nvidia-driver; env -u CC -u CXX -u CP= P PATH=3D/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/leg= acy/usr/bin:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sb= in:/usr/obj/usr/src/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/loca= l/bin:/usr/local/sbin SRC_BASE=3D/usr/src OSVERSION=3D1100506 WRKDIR= PREFIX=3D/usr/obj/usr/src/sys/WS01 GENERIC make -B clean all After: =3D=3D=3D> Ports module x11/nvidia-driver (all) cd ${PORTSDIR:-/usr/ports}/x11/nvidia-driver; env -u CC -u CXX -u CP= P PATH=3D/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/leg= acy/usr/bin:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sb= in:/usr/obj/usr/src/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/loca= l/bin:/usr/local/sbin SRC_BASE=3D/usr/src OSVERSION=3D1100506 WRKDIR= PREFIX=3D/usr/obj/usr/src/sys/WS01 make -B clean all -- Herbert