From owner-cvs-all Tue Nov 2 18:22:18 1999 Delivered-To: cvs-all@freebsd.org Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7]) by hub.freebsd.org (Postfix) with ESMTP id 90DE014EE8; Tue, 2 Nov 1999 18:22:09 -0800 (PST) (envelope-from archie@whistle.com) Received: (from archie@localhost) by bubba.whistle.com (8.9.2/8.9.2) id SAA75822; Tue, 2 Nov 1999 18:22:03 -0800 (PST) From: Archie Cobbs Message-Id: <199911030222.SAA75822@bubba.whistle.com> Subject: Re: cvs commit: src/sys/i386/isa spkr.c src/sys/kern subr_scanf.c src/sys/pc98/pc98 spkr.c src/sys/sys systm.h In-Reply-To: from Bruce Evans at "Nov 3, 1999 01:02:46 pm" To: bde@zeta.org.au (Bruce Evans) Date: Tue, 2 Nov 1999 18:22:03 -0800 (PST) Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Bruce Evans writes: > > Modified files: > > sys/i386/isa spkr.c > > sys/kern subr_scanf.c > > sys/pc98/pc98 spkr.c > > sys/sys systm.h > > Log: > > Consolidate some of the various ctype(3) macros in one location. > > That location should be libkern/ctype.h so that it doesn't pollute > everything and so that libkern files can use the same #includes as > their libc versions (INCLUDES+= -I$S/libkern). Yeah, I like that idea better too. I wasn't clear about doing that way though.. e.g., why was strtoul() put inside kern/subr_scanf.c instead of libkern? I was following that example. Maybe strtoul() should be moved to a new file libkern/strtoul.c.. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message