From nobody Mon Nov 22 09:36:41 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D4BD01894B46; Mon, 22 Nov 2021 09:36:48 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HyMc05ddjz3G4v; Mon, 22 Nov 2021 09:36:48 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8604456ED; Mon, 22 Nov 2021 09:36:48 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:42:0:ed9c:3100:d53d:d3cb]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 9C566942D81; Mon, 22 Nov 2021 09:36:45 +0000 (UTC) Date: Mon, 22 Nov 2021 10:36:41 +0100 From: Mathieu Arnold To: Po-Chuan Hsieh Cc: Matthias Fechner , bradleythughes@fastmail.fm, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 46ce086c7130 - main - Mk/Uses: default version for nodejs Message-ID: <20211122093641.kahj22hop4fngimk@aching.in.mat.cc> References: <202111120555.1AC5tGbw088641@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wob55msphxv4npu5" Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N --wob55msphxv4npu5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 22, 2021 at 05:18:45AM +0800, Po-Chuan Hsieh wrote: > Here's the patch [1] which does not have www/node in gitlab's dependencie= s. > I'll commit it later. >=20 > [1] https://people.FreeBSD.org/~sunpoet/patch/node.txt I don't think using a development version of node by default is a good idea. Having it to make sure it still build during its development is ok, but using it as the default is bad. Using 14 or 16 as the default is ok, lts is probably even better. --=20 Mathieu Arnold --wob55msphxv4npu5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEFD4jMKwz5Ud8Ywu3ecmT/A9inX0FAmGbZKlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE0 M0UyMzMwQUMzM0U1NDc3QzYzMEJCNzc5Qzk5M0ZDMEY2MjlEN0QACgkQecmT/A9i nX3B/wf/RdHc+VnGfBLiwk+jf0YrIE7WtjqOyHjlvZsoMZuFor47cooqOYgWvRZV Fe1CuSORr3/1q3dHU1GBX3x5c3v/T82YKyjN1wFl2ITuUPpKwdx6tX6CM/icnGNS AejeKse1VS+XMlmykEDyBJFWTt3cj0Cq7fLTXkYZOb7uYexTrhnBWsYwrvivL2p8 HUb1TEAE2pQmvF/Ookmp1B5pTRenCWF3xmvUs2w/oaQviIBSAfEZ1zh64O2HNbA2 buG1jIyqXVxOhU1aj1ZjC9GwJfjs+ff8TjpncwlvXjYTwMMuMkzQ37tJ1MWMV1H+ POAtiIgXDD20NS1+f1x8Gemc0S5+1Q== =/w6U -----END PGP SIGNATURE----- --wob55msphxv4npu5--