From owner-svn-src-stable-8@FreeBSD.ORG Mon Jun 3 16:47:47 2013 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 841D7943; Mon, 3 Jun 2013 16:47:47 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 74DA019CA; Mon, 3 Jun 2013 16:47:47 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r53GllRx074537; Mon, 3 Jun 2013 16:47:47 GMT (envelope-from jkim@svn.freebsd.org) Received: (from jkim@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r53GllMR074536; Mon, 3 Jun 2013 16:47:47 GMT (envelope-from jkim@svn.freebsd.org) Message-Id: <201306031647.r53GllMR074536@svn.freebsd.org> From: Jung-uk Kim Date: Mon, 3 Jun 2013 16:47:47 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r251308 - stable/8/usr.sbin/acpi/acpidump X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 16:47:47 -0000 Author: jkim Date: Mon Jun 3 16:47:46 2013 New Revision: 251308 URL: http://svnweb.freebsd.org/changeset/base/251308 Log: MFC: r251186 Fix a long standing logic bug introduced in r167814. The code was added to get RSDP from loader(8) hint via kenv(2) but the bug nullified the new code and we always fell back to the previous method, i. e., sysctlbyname(3). Modified: stable/8/usr.sbin/acpi/acpidump/acpi_user.c Directory Properties: stable/8/usr.sbin/acpi/acpidump/ (props changed) Modified: stable/8/usr.sbin/acpi/acpidump/acpi_user.c ============================================================================== --- stable/8/usr.sbin/acpi/acpidump/acpi_user.c Mon Jun 3 16:46:37 2013 (r251307) +++ stable/8/usr.sbin/acpi/acpidump/acpi_user.c Mon Jun 3 16:47:46 2013 (r251308) @@ -172,7 +172,7 @@ acpi_find_rsd_ptr(void) addr = 0; /* Attempt to use kenv or sysctl to find RSD PTR record. */ - if (kenv(KENV_GET, hint_acpi_0_rsdp, buf, 20) == 0) + if (kenv(KENV_GET, hint_acpi_0_rsdp, buf, 20) > 0) addr = strtoul(buf, NULL, 0); if (addr == 0) { len = sizeof(addr);