From owner-freebsd-bugs  Sun Mar 11 16: 7:33 2001
Delivered-To: freebsd-bugs@freebsd.org
Received: from obsecurity.dyndns.org (adsl-63-207-60-158.dsl.lsan03.pacbell.net [63.207.60.158])
	by hub.freebsd.org (Postfix) with ESMTP
	id ECB4C37B718; Sun, 11 Mar 2001 16:07:25 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 412E866F14; Sun, 11 Mar 2001 16:07:24 -0800 (PST)
Date: Sun, 11 Mar 2001 16:07:24 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Yifeng Xu <websoft@yahoo.com>
Cc: freebsd-questions@freebsd.org, ache@nagual.pp.ru,
	freebsd-bugs@FreeBSD.org
Subject: Re: **HEADS UP** bug fix for pr25439 (patch)
Message-ID: <20010311160724.A70656@mollari.cthul.hu>
References: <20010304124849.10752.qmail@web1704.mail.yahoo.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF"
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010304124849.10752.qmail@web1704.mail.yahoo.com>; from websoft@yahoo.com on Sun, Mar 04, 2001 at 04:48:49AM -0800
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


--3MwIy2ne0vdjdPXF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Please submit this as a followup to the PR so that it is tracked in
the bug DB.

Kris

On Sun, Mar 04, 2001 at 04:48:49AM -0800, Yifeng Xu wrote:
> Hi,
>=20
> I am sorry it seems my SMTP server has problems, so I send it via Yahoo!
> you may received my several previous sents.=20
>=20
> I think I found the bug about annoying console mouse cursor flicker
> problem reported in http://www.freebsd.org/cgi/query-pr.cgi?pr=3D25439
> by me sometimes ago, the bug is in file=20
> /sys/dev/syscons/syscons.c where function scrn_update will hide=20
> and redraw mouse cursor in a special area:
>=20
> ..........................
> ..........................
> ..........................
> ..........................
> ..........................
> ..........................
> ..XXXXXXXXXXXXXXXXXXXXXXXX
> XX@.......................
> ..........................
>=20
> the above image represents a full image of console screen,
> every line represents a line on screen, char @ represents=20
> TEXT CURSOR position, area marked with 'X' is an unsafe area,=20
> if mouse cursor is moved into this area, syscons will become=20
> weird, mouse cursor flickers in very fast speed, eats CPU time=20
> up to 20%.
>=20
> the following is a patch to fix this problem. I wish=20
> the bug is fixed before FreeBSD 4.3 rolls out. this is a long
> standing bug. hurray!
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> --- syscons.c.orig Sun Mar  4 16:18:59 2001
> +++ syscons.c Sun Mar  4 16:22:33 2001
> @@ -1719,12 +1719,9 @@
>      /* remove the previous mouse pointer image if necessary */
>      if (scp->status & MOUSE_VISIBLE) {
>   s =3D scp->mouse_pos;
> - e =3D scp->mouse_pos + scp->xsize + 1;
> + e =3D scp->mouse_pos;
>   if ((scp->status & (MOUSE_MOVED | MOUSE_HIDDEN))
> -     || and_region(&s, &e, scp->start, scp->end)
> -     || ((scp->status & CURSOR_ENABLED) &&=20
> -  (and_region(&s, &e, scp->cursor_pos, scp->cursor_pos)
> -   || and_region(&s, &e, scp->cursor_oldpos, scp->cursor_oldpos)))) {
> +     || and_region(&s, &e, scp->start, scp->end)) {
>       sc_remove_mouse_image(scp);
>       if (scp->end >=3D scp->xsize*scp->ysize)
>    scp->end =3D scp->xsize*scp->ysize - 1;
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> David Xu
> davidx@viasoft.com.cn
>=20
>=20
> __________________________________________________
> Do You Yahoo!?
> Get email at your own domain with Yahoo! Mail.=20
> http://personal.mail.yahoo.com/
>=20
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-bugs" in the body of the message
>=20

--3MwIy2ne0vdjdPXF
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE6rBM7Wry0BWjoQKURAmhMAJ48OJLKFlyWalEWYRllciw8f1/IrgCghfi4
83anOvKRaDn9bDxawOynDKg=
=YoJb
-----END PGP SIGNATURE-----

--3MwIy2ne0vdjdPXF--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message