From owner-freebsd-stable@FreeBSD.ORG Fri Jan 18 00:29:01 2008 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7072716A41B for ; Fri, 18 Jan 2008 00:29:01 +0000 (UTC) (envelope-from volker@vwsoft.com) Received: from frontmail.ipactive.de (frontmail.maindns.de [85.214.95.103]) by mx1.freebsd.org (Postfix) with ESMTP id E7E8213C46A for ; Fri, 18 Jan 2008 00:29:00 +0000 (UTC) (envelope-from volker@vwsoft.com) Received: from mail.vtec.ipme.de (F7265.f.ppp-pool.de [195.4.114.101]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by frontmail.ipactive.de (Postfix) with ESMTP id 3BF7712883F; Fri, 18 Jan 2008 00:55:50 +0100 (CET) Received: from cesar.sz.vwsoft.com (unknown [192.168.16.33]) by mail.vtec.ipme.de (Postfix) with ESMTP id D79593F43B; Fri, 18 Jan 2008 00:54:14 +0100 (CET) Message-ID: <478FEAF5.2080008@vwsoft.com> Date: Fri, 18 Jan 2008 00:55:33 +0100 From: Volker User-Agent: Thunderbird 2.0.0.9 (X11/20080113) MIME-Version: 1.0 To: Nate Lawson References: <47893F8B.7010805@root.org> <4789756B.8060203@vwsoft.com> <4789B267.1000505@root.org> <478BB3F4.7050600@root.org> In-Reply-To: <478BB3F4.7050600@root.org> X-Enigmail-Version: 0.95.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit MailScanner-NULL-Check: 1201218867.54708@PaqYtmJ2TBxo32DxeAzDpA X-VWSoft-MailScanner: Found to be clean X-MailScanner-From: volker@vwsoft.com X-ipactive-MailScanner-Information: Please contact the ISP for more information X-ipactive-MailScanner: Found to be clean X-ipactive-MailScanner-From: volker@vwsoft.com Cc: stable@freebsd.org, current@FreeBSD.org Subject: Re: Re: Fix for GPE livelock on HPs X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2008 00:29:01 -0000 On 12/23/-58 20:59, Nate Lawson wrote: > Nate Lawson wrote: >> Volker wrote: >>> On 12/23/-58 20:59, Nate Lawson wrote: >>>> I've committed the below patch and want to MFC it to 7.0. To do this, I >>>> need people to test this quickly. It probably has no effect in 6.x and >>>> probably doesn't apply cleanly there. >>>> >>>> Please try this patch if you have a laptop and 7.x. If you have >>>> -current, just cvsup. I'd like to make sure there is no regression. >>>> I'm already aware that it fixes things for some HP users. >>> Nate, >>> >>> can you be a bit specific for a) what GPE is, b) what the problem is, >>> c) what to look for (any test procedures?) and d) which HP laptop >>> models might be affected? >>> >>> I do have an Omnibook vt6200 (P-IV 1.8G) running 6-STABLE and a new HP >>> 6715b (Tur-X2 TL-60) running 7-RC1 (currently installing on this, OS >>> is not yet fully set up). >>> >>> If I knew what to look for, I might test your patches (at least on the >>> 7-RC1 version). >> A GPE is an interrupt of sorts. I'm looking for any bad behavior the >> patch might cause. I'm certain it fixes lockups some HPs had during >> thermal zone events (i.e. fan switching on when it gets hot). Pretty >> much anyone with a laptop that locks up and you suspect acpi should test >> it. And anyone who is willing to test it on another brand laptop to be >> sure the patch doesn't break anything more would be welcome. >> >> You should be able to do "sysctl hw.acpi" and see the temperature and >> "apm" to see battery status without any new problems after applying the >> patch. > > I've added a patch for 6-stable also (attached). Please test if you > have a laptop and 6.x. See -current for the 7.x patch if that's > relevant to you. > > -Nate > Nate, I'm sorry, your patch applies cleanly but does not compile on 6-STABLE (csup'ed today, applied patch defer_gpe_6x.diff posted on 2008-01-15). ===> acpi/acpi (all) cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I- -I/usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica -DHAVE_KERNEL_OPTIO N_HEADERS -include /usr/obj/usr/src/sys/CESAR/opt_global.h -I. -I@ -I@/contrib/a ltq -I@/../include -finline-limit=8000 -fno-common -g -I/usr/obj/usr/src/sys/CES AR -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mn o-sse -mno-sse2 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict -prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat -extensions -std=c99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uniniti alized -c /usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica/evgpe.c /usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica/evgpe.c: In function `AcpiEvAsynchExecuteGpeMethod': /usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica/evgpe.c:664: warning: implicit declaration of function `AcpiOsExecute' /usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica/evgpe.c:664: warning: nested extern declaration of `AcpiOsExecute' /usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica/evgpe.c:664: error: ` OSL_NOTIFY_HANDLER' undeclared (first use in this function) /usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica/evgpe.c:664: error: ( Each undeclared identifier is reported only once /usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica/evgpe.c:664: error: for each function it appears in.) *** Error code 1 Stop in /usr/src/sys/modules/acpi/acpi. BTW, reading the source code changes and your commit comments, I'm pretty sure I've seen those ACPI related problems on my HP Omnibook vt6200 using 6-STABLE. Sometimes the tz0 temperature values have been nailed to a fixed value, sometimes the system went too hot (with or without the fan running), sometimes it was just freezing and no way out to revitalize the notebook. I haven't reported this before because something like "my system freezes w/o message" or "the system does stupid things but I don't have an error message" is most likely not the kind of report to get a useful reply for. If you've got another patch for a 6-STABLE target, I'll be happy to test. Thanks! Volker