Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Apr 2012 05:33:28 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r233860 - stable/8/sys/ufs/ufs
Message-ID:  <201204040533.q345XS8v087020@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Apr  4 05:33:28 2012
New Revision: 233860
URL: http://svn.freebsd.org/changeset/base/233860

Log:
  MFC r233608:
  Microoptimize: in qsync loop over mount vnodes, only unlock mount
  interlock after we committed to try to vget() the vnode.

Modified:
  stable/8/sys/ufs/ufs/ufs_quota.c
Directory Properties:
  stable/8/sys/   (props changed)

Modified: stable/8/sys/ufs/ufs/ufs_quota.c
==============================================================================
--- stable/8/sys/ufs/ufs/ufs_quota.c	Wed Apr  4 05:29:21 2012	(r233859)
+++ stable/8/sys/ufs/ufs/ufs_quota.c	Wed Apr  4 05:33:28 2012	(r233860)
@@ -915,12 +915,11 @@ qsync(struct mount *mp)
 again:
 	MNT_VNODE_FOREACH(vp, mp, mvp) {
 		VI_LOCK(vp);
-		MNT_IUNLOCK(mp);
 		if (vp->v_type == VNON) {
 			VI_UNLOCK(vp);
-			MNT_ILOCK(mp);
 			continue;
 		}
+		MNT_IUNLOCK(mp);
 		error = vget(vp, LK_EXCLUSIVE | LK_INTERLOCK, td);
 		if (error) {
 			MNT_ILOCK(mp);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204040533.q345XS8v087020>