From owner-freebsd-fs@FreeBSD.ORG Wed Sep 15 21:54:43 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91EEB1065670; Wed, 15 Sep 2010 21:54:43 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 102678FC14; Wed, 15 Sep 2010 21:54:42 +0000 (UTC) Received: by vws7 with SMTP id 7so475775vws.13 for ; Wed, 15 Sep 2010 14:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=J7KvFj3tyTrFcbcBBQYB9+BvevJnPQ+hLO+VzJzMvbg=; b=I94H6ff0VYpIE0VEpwD2U9QoARibOd1BXvgkNN1pIWnt1lTnhxT8xXNXL8mWTPcQrg OliLcguWKTi1CQtK8gdqqooB1EJ55h8vqePzZf3r23ZF+7jERyqbiDm6u2tMJOzneJ8h lUK8OjlFVQi/OJsCf7njpyIGdbT5C9Bw4kvfQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=IhmXNPCEjFsI6eJ8//gfO69KTOfKojU3gVgOK2F0XF2cf3r0xez3B/ZcK8E4tZ5NlL KhQX2BQMm909qE54pcSQS/mCR2qIHxIRmfWGYXVg2Op+ocFT9gV7sQj6vKmaSQZAoNxS U90SdfxIisGOykk6EaeD1qjWAs4CHTGVl0AMo= Received: by 10.220.49.16 with SMTP id t16mr1311709vcf.59.1284587682377; Wed, 15 Sep 2010 14:54:42 -0700 (PDT) Received: from centel.dataix.local (adsl-99-181-146-122.dsl.klmzmi.sbcglobal.net [99.181.146.122]) by mx.google.com with ESMTPS id a15sm1025352vci.13.2010.09.15.14.54.40 (version=SSLv3 cipher=RC4-MD5); Wed, 15 Sep 2010 14:54:41 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C91409F.9090204@DataIX.net> Date: Wed, 15 Sep 2010 17:54:39 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.9) Gecko/20100908 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: Steven Hartland References: <20100908084855.GF2465@deviant.kiev.zoral.com.ua> <4C874F00.3050605@freebsd.org> <4C8D087B.5040404@freebsd.org> <03537796FAB54E02959E2D64FC83004F@multiplay.co.uk> <4C8D280F.3040803@freebsd.org> <3FBF66BF11AA4CBBA6124CA435A4A31B@multiplay.co.uk> <4C8E4212.30000@freebsd.org> <20100915104635.GA59871@icarus.home.lan> <8E233260F0334BC58B2C07F383939F8E@multiplay.co.uk> <4C9131F6.10807@DataIX.net> In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, Pawel Jakub Dawidek , Andriy Gapon Subject: Re: zfs very poor performance compared to ufs due to lack of cache? X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 21:54:43 -0000 On 09/15/2010 17:30, Steven Hartland wrote: > ----- Original Message ----- From: "jhell" jhell@DataIX.net > >> On 09/15/2010 06:54, Steven Hartland wrote: >>> ----- Original Message ----- From: "Jeremy Chadwick" >>> >>>> Looks like Andriy just committed something to HEAD/CURRENT which might >>>> address this: >>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/141305 >>> >>> Already running that as part of the patches unfortunately, it doesn't >>> seem >>> to have any effect. >>> >> >> Is it ? vm_page_set_validclean(m, off, bytes); >> I recall you saying that you added this from earlier in the thread. >> could be wrong though but what Andriy committed was the following. >> >> or ? vm_page_set_valid(m, off, bytes); > > > Ahh good catch I have: > if (error == 0) > vm_page_set_validclean(m, off, bytes); > > and not as mentioned by 141305: > if (error == 0) > vm_page_set_valid(m, off, bytes); > > Which should it actaully be? > Looking at the manual page vm_page_bits(9) I don't see a vm_page_is_validclean so really would it have a effect ?. -- jhell,v