From owner-freebsd-bugs Sat Jul 24 4:53:12 1999 Delivered-To: freebsd-bugs@freebsd.org Received: from elixir.e.kth.se (elixir.e.kth.se [130.237.48.5]) by hub.freebsd.org (Postfix) with ESMTP id 9364515053; Sat, 24 Jul 1999 04:53:05 -0700 (PDT) (envelope-from lha@e.kth.se) Received: from hummel.e.kth.se (hummel.e.kth.se [130.237.43.135]) by elixir.e.kth.se (8.9.3/8.9.3) with ESMTP id NAA13069; Sat, 24 Jul 1999 13:52:02 +0200 (MET DST) Received: (from lha@localhost) by hummel.e.kth.se (8.9.3/8.9.3) id NAA25805; Sat, 24 Jul 1999 13:52:02 +0200 (MET DST) To: n_hibma@FreeBSD.org Cc: freebsd-bugs@FreeBSD.org Subject: Re: bin/873: atoi and modunload References: <199907241135.EAA36699@freefall.freebsd.org> From: Love Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII Date: 24 Jul 1999 13:52:00 +0200 In-Reply-To: n_hibma@FreeBSD.org's message of Sat, 24 Jul 1999 04:35:14 -0700 (PDT) Message-ID: Lines: 35 X-Mailer: Gnus v5.5/Emacs 20.2 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org n_hibma@FreeBSD.org writes: > Synopsis: atoi and modunload > > State-Changed-From-To: open->closed > State-Changed-By: n_hibma > State-Changed-When: Sat Jul 24 04:34:06 PDT 1999 > State-Changed-Why: > kldload (replacement of modunload) shows usage() when a number > smaller then 1 or not a number is entered. This time its not fatal but couldn't you fix so kldunload.c would accully give a sane error message when the user did wrong, please ? Love --- kldunload.c.orig Sat Jul 24 13:46:27 1999 +++ kldunload.c Sat Jul 24 13:49:45 1999 @@ -51,11 +51,14 @@ int verbose = 0; int fileid = 0; char* filename = 0; + char *endptr; while ((c = getopt(argc, argv, "i:n:v")) != -1) switch (c) { case 'i': - fileid = atoi(optarg); + fileid = strtol(optarg, &endptr, 0); + if (*endptr != '\0') + errx(1, "not a valid number"); break; case 'n': filename = optarg; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message