From owner-freebsd-current Sat Jan 10 19:32:19 1998 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id TAA03650 for current-outgoing; Sat, 10 Jan 1998 19:32:19 -0800 (PST) (envelope-from owner-freebsd-current) Received: from lsd.relcom.eu.net (root@lsd.relcom.eu.net [193.124.23.23]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id TAA03554; Sat, 10 Jan 1998 19:31:42 -0800 (PST) (envelope-from ache@lsd.relcom.eu.net) Received: (from ache@localhost) by lsd.relcom.eu.net (8.8.8/8.8.8) id BAA03779; Sun, 11 Jan 1998 01:30:26 +0300 (MSK) (envelope-from ache) Date: Sun, 11 Jan 1998 01:30:23 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= X-Sender: ache@lsd.relcom.eu.net To: Joerg Wunsch cc: Mike Smith , FreeBSD-current , peter@FreeBSD.ORG Subject: Re: CVS DIFF fix for review (-L added) In-Reply-To: <19980110195007.31038@uriah.heep.sax.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sat, 10 Jan 1998, J Wunsch wrote: > I didn't look into the code yet, but i was hoping something like > > run_setup("%s %s -L %s -L %s %s", ...) > > would work? Yes, it would be simpler. I write function keeping more complex labels in mind, something like: \t (with embedded spaces), then find that it is not neccessary. I'll make simplified version of the patch and send it ASAP. > Also, i'm not sure, but IMHO the Index: lines should be dropped then. > They are obsolete at best, and confusing at worst. Index: lines still needed for ed-style diffs. Such case detection adds more code. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/