Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Aug 2016 23:55:26 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-fs@FreeBSD.org
Subject:   [Bug 212168] [panic] [UFS] use-after-free panic (0xdeadc0dedeadc0de)
Message-ID:  <bug-212168-3630-ygL9J9asRt@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-212168-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-212168-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212168

--- Comment #10 from Kirk McKusick <mckusick@FreeBSD.org> ---
It appears that there is an item on the worklist that has been prematurely
freed. This freeing should be impossible as anything on a worklist has its
ONWORKLIST flag set and the worklist freeing routine will panic if the
ONWORKLIST flag is set. However I have written the following check to see i=
f we
are finding freed items on the worklist in softdep_disk_io_initiation():

Index: sys/ufs/ffs/ffs_softdep.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/ufs/ffs/ffs_softdep.c   (revision 305057)
+++ sys/ufs/ffs/ffs_softdep.c   (working copy)
@@ -9949,6 +9949,13 @@

        if ((wk =3D LIST_FIRST(&bp->b_dep)) =3D=3D NULL)
                return;
+       if (wk->wk_type > D_LAST + 1) {
+               printf("dead worklist: %p next %p prev %p type %s state
0x%X\n",
+                   wk, wk->wk_list.le_next, wk->wk_list.le_prev,
+                   TYPENAME(wk->wk_type), wk->wk_state);
+               LIST_INIT(&bp->b_dep);
+               return;
+       }
        ump =3D VFSTOUFS(wk->wk_mp);

        marker.wk_type =3D D_LAST + 1;    /* Not a normal workitem */

I would appreciate your running with this patch and reporting if you get the
"dead worklist" error message.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-212168-3630-ygL9J9asRt>