From owner-freebsd-current@freebsd.org Fri Aug 31 04:21:07 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1E9FF7294F for ; Fri, 31 Aug 2018 04:21:06 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.protected-networks.net (mail.protected-networks.net [IPv6:2001:470:8d59:1::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protected-networks.net", Issuer "Protected Networks CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8ECCF80E7E; Fri, 31 Aug 2018 04:21:06 +0000 (UTC) (envelope-from imb@protected-networks.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= protected-networks.net; h=content-transfer-encoding :content-language:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:from:from :references:subject:subject; s=201508; t=1535689263; bh=LuuLvSl2 /wsCEMb4+T9nsrJjGcsmcplhtgtFAwshEgE=; b=SL4qQx7bVg8StbZJhf+AuFsE Ovp71PDEbPMMoxxBG4rOB82RpyTWHJV5X3X8JGVuveKPdTJ76VCHHT2Ko6Nd9HYK jMDGxvJE279mbI+Z/inkGpiGWDkzhOyGIlqBxF1n53WfD6iFxMWTcfTch6OJ1iPC uSs3/Z+EfF0u+YieV2M= Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [192.168.1.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: imb@mail.protected-networks.net) by mail.protected-networks.net (Postfix) with ESMTPSA id ADD357345; Fri, 31 Aug 2018 00:21:03 -0400 (EDT) Subject: Re: intr_machdep.c:176:2: error: use of undeclared identifier 'interrupt_sorted' To: John Baldwin , Ian FREISLICH , freebsd-current References: <524214ac-e3ca-53cd-aee3-dac9212e9800@capeaugusta.com> <0aa35f96-9f62-bfca-c04a-f6ddcb1ce738@FreeBSD.org> From: Michael Butler Openpgp: preference=signencrypt Message-ID: <8ed7961e-e12a-9267-2bd0-a9bcbe383c7f@protected-networks.net> Date: Fri, 31 Aug 2018 00:21:02 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <0aa35f96-9f62-bfca-c04a-f6ddcb1ce738@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 04:21:07 -0000 On 8/29/18 7:40 PM, John Baldwin wrote: > On 8/29/18 4:20 PM, Ian FREISLICH wrote: >> Hi >> >> I see the definition of interrupt_sorted is #ifdefed out by #ifdef SMP >> at line 84.  My system is UP so I'm not compiling an SMP kernel. >> >> /usr/src/sys/x86/x86/intr_machdep.c:176:2: error: use of undeclared >> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'? >>         interrupt_sorted = mallocarray(num_io_irqs, >> sizeof(*interrupt_sorted), >>         ^~~~~~~~~~~~~~~~ >>         interrupt_sources >> /usr/src/sys/x86/x86/intr_machdep.c:83:24: note: 'interrupt_sources' >> declared here >> static struct intsrc **interrupt_sources; >>                        ^ >> /usr/src/sys/x86/x86/intr_machdep.c:176:54: error: use of undeclared >> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'? >>         interrupt_sorted = mallocarray(num_io_irqs, >> sizeof(*interrupt_sorted), > > Probably just needs #ifdef SMP around the mallocarray(). I'll test locallyon a UP kernel config. > I see another problem after using Ian's workaround of moving the #ifdef SMP; it seems I now run out of kernel stack on an i386 (Pentium-III) machine with only 512MB of RAM: Aug 29 23:29:19 sarah kernel: vm_thread_new: kstack allocation failed Aug 29 23:29:26 sarah kernel: vm_thread_new: kstack allocation failed Aug 29 23:29:30 sarah kernel: vm_thread_new: kstack allocation failed Aug 29 23:29:38 sarah kernel: vm_thread_new: kstack allocation failed Aug 29 23:29:38 sarah kernel: vm_thread_new: kstack allocation failed Aug 29 23:29:40 sarah kernel: vm_thread_new: kstack allocation failed imb