Date: Sat, 2 Feb 2013 23:12:52 +0100 From: Stefan Bethke <stb@lassitu.de> To: Kimmo Paasiala <kpaasial@gmail.com> Cc: FreeBSD Stable Mailing List <freebsd-stable@freebsd.org>, miwi@freebsd.org, Brooks Davis <brooks@freebsd.org>, Dimitry Andric <dim@freebsd.org> Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 Message-ID: <EC626FC8-31B9-44BF-B2C8-7F3C75393AB9@lassitu.de> In-Reply-To: <CA%2B7WWScAqRa2Yurpgg5bH5FB=vQ6vYXGtz56qadcV9RgAcP=SQ@mail.gmail.com> References: <CA%2B7WWSeOpuAv9PL2_G6Z1Q_SLv5xcTjcujiw6Rs8tdBsrLO7wQ@mail.gmail.com> <50F6D20A.6070306@FreeBSD.org> <CA%2B7WWSfE1bAr7GriRGAKBVpkiNE%2Btn-%2Bd0cO3vpNPY-SWxfghg@mail.gmail.com> <20130117001116.GD29437@lor.one-eyed-alien.net> <CA%2B7WWSdW95=qBthPKWtn1uT_FTD2ka-oQXLo-owFEn=kO4GYRg@mail.gmail.com> <50F81588.5020106@FreeBSD.org> <CA%2B7WWSfrpvJXAqrn8d=j1yXZmUw_itxtxJyxYExPnE-JNE2%2Bpw@mail.gmail.com> <51081E18.60303@sentex.net> <CA%2B7WWSfvit0G_LL57e6dU%2BZRWnrgip_pwGUqtSudfu_UPqzkmQ@mail.gmail.com> <CAD4099nFbzRyFSeQ4NN7J7ts0fXijsOf%2BjrCXn7WrauyWPJcrw@mail.gmail.com> <CA%2B7WWScAqRa2Yurpgg5bH5FB=vQ6vYXGtz56qadcV9RgAcP=SQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 30.01.2013 um 07:21 schrieb Kimmo Paasiala <kpaasial@gmail.com>: > On Wed, Jan 30, 2013 at 7:27 AM, James <james@hicag.org> wrote: >> I was able to correct the problem as well by prefixing strnvis, = avoiding the >> symbol collision. I also found PR: ports/172941 which also has a fix. >>=20 >> Using my patch or the patch in ports/172941 fixes the segfault for me = in >> stable/9. However, I quickly ran into another problem. I can't = remember the >> error message exactly, it was something like "Unable to initialize = PAM: >> Unknown file descriptor". A ktrace didn't reveal anything obvious. = I'll try >> to test it out tomorrow. >>=20 >> -- >> James. >=20 > Try the attached patch. Just drop it into > /usr/ports/security/pam_ssh_agent_auth/files directory and recompile. >=20 > This will make the port use the system strnvis() with correctly > ordered arguments if one is available (HAVE_STRNVIS defined) and an > _openbsd suffixed version if not. >=20 >=20 > -Kimmo > <patch-strnvis.txt> Working great for me! Is this on any committers radar? I don't see a PR for it. Stefan --=20 Stefan Bethke <stb@lassitu.de> Fon +49 151 14070811
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EC626FC8-31B9-44BF-B2C8-7F3C75393AB9>