From owner-freebsd-bugs@freebsd.org Mon May 16 10:24:11 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5585DB3C787 for ; Mon, 16 May 2016 10:24:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2C5A31A61 for ; Mon, 16 May 2016 10:24:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u4GAOBc5002355 for ; Mon, 16 May 2016 10:24:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 209546] [PATCH] libfetch: doesn't support HTTP 307 redirects Date: Mon, 16 May 2016 10:24:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: novel@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 10:24:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209546 Bug ID: 209546 Summary: [PATCH] libfetch: doesn't support HTTP 307 redirects Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: novel@FreeBSD.org Keywords: patch Created attachment 170348 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D170348&action= =3Dedit proposed fix, v1 Currently, fetch(1) fails to download a file if there's HTTP 307 redirect f= or it. For example: $ fetch https://jigsaw.w3.org/HTTP/300/307.html fetch: https://jigsaw.w3.org/HTTP/300/307.html: Temporary Redirect $ However, it should not fail on redirect unless -A flag was given. Additionally, in verbose mode it manages to download that file. This appears to happen because in "switch (http_get_reply(conn))" in http_request_body() from http.c there's no case for HTTP_TEMP_REDIRECT, so = it fails to "default" that looks like this: 1816 default: 1817 http_seterr(conn->err); 1818 if (!verbose) 1819 goto ouch; So in verbose mode it goes further and downloads the file, because HTTP_REDIRECT() macro does include check for HTTP_TEMP_REDIRECT. Fix by handing HTTP_TEMP_REDIRECT in the http_get_reply(conn) switch. --=20 You are receiving this mail because: You are the assignee for the bug.=