From owner-freebsd-bugs  Thu Jul 20  6:10: 5 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 87A9C37B6C6
	for <freebsd-bugs@FreeBSD.org>; Thu, 20 Jul 2000 06:10:00 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id GAA39501;
	Thu, 20 Jul 2000 06:10:00 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from mx7.mail.ru (mx7.mail.ru [194.67.23.44])
	by hub.freebsd.org (Postfix) with ESMTP id E189A37B54D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 20 Jul 2000 06:06:25 -0700 (PDT)
	(envelope-from kabaev@mail.ru)
Received: from adsl-141-154-74-123.bellatlantic.net ([141.154.74.123] helo=kan.ne.mediaone.net)
	by mx7.mail.ru with esmtp (Exim 3.14 #4)
	id 13FG1r-00044j-00
	for FreeBSD-gnats-submit@freebsd.org; Thu, 20 Jul 2000 17:06:19 +0400
Received: (from kan@localhost)
	by kan.ne.mediaone.net (8.9.3/8.9.3) id JAA00453;
	Thu, 20 Jul 2000 09:03:19 -0400 (EDT)
	(envelope-from kan)
Message-Id: <200007201303.JAA00453@kan.ne.mediaone.net>
Date: Thu, 20 Jul 2000 09:03:19 -0400 (EDT)
From: kabaev@mail.ru
Reply-To: kabaev@mail.ru
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/20057: M_WAITOK in interrupt context panic in NETGRAPH 
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         20057
>Category:       kern
>Synopsis:       netgraph panics in ng_base.c:ng_path2node
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 20 06:10:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Alexander N. Kabaev
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:

FreeBSD kan.ne.mediaone.net 5.0-CURRENT FreeBSD 5.0-CURRENT #2: Thu Jul 20 00:13:12 EDT 2000     kan@kan.ne.mediaone.net:/usr/src/sys/compile/KAN  i386

>Description:

   ng_path2node function is sometimes called from the interrupt context
   (from SWI => ng_intr => ng_pppoe_??? .... => ng_path2node), yet it
   allocates memory buffer with M_WAITOK. That causes the above mentioned
   panic. 

>How-To-Repeat:

   use ppp in PPPoe mode with INVARIANTS in the kernel

>Fix:

Index: ng_base.c
===================================================================
RCS file: /home/ncvs/src/sys/netgraph/ng_base.c,v
retrieving revision 1.20
diff -u -r1.20 ng_base.c
--- ng_base.c	2000/05/26 02:05:38	1.20
+++ ng_base.c	2000/07/20 12:48:06
@@ -1100,7 +1100,7 @@
 
 	/* Now compute return address, i.e., the path to the sender */
 	if (rtnp != NULL) {
-		MALLOC(*rtnp, char *, NG_NODELEN + 2, M_NETGRAPH, M_WAITOK);
+		MALLOC(*rtnp, char *, NG_NODELEN + 2, M_NETGRAPH, M_NOWAIT);
 		if (*rtnp == NULL) {
 			TRAP_ERROR;
 			return (ENOMEM);


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message