From owner-freebsd-hackers@FreeBSD.ORG Sun Jul 31 02:35:10 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EA1116A420 for ; Sun, 31 Jul 2005 02:35:10 +0000 (GMT) (envelope-from koma2@lovepeers.org) Received: from www235.sakura.ne.jp (www235.sakura.ne.jp [202.181.97.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61A2143D48 for ; Sun, 31 Jul 2005 02:35:07 +0000 (GMT) (envelope-from koma2@lovepeers.org) Received: from [192.168.11.9] (61-26-245-137.rev.home.ne.jp [61.26.245.137]) (authenticated bits=0) by www235.sakura.ne.jp (8.12.11/8.12.11) with ESMTP id j6V2YotJ084294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 31 Jul 2005 11:34:56 +0900 (JST) (envelope-from koma2@lovepeers.org) Message-ID: <42EC38C9.8070402@lovepeers.org> Date: Sun, 31 Jul 2005 11:34:49 +0900 From: KOMATSU Shinichiro User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) X-Accept-Language: ja, en-us, en MIME-Version: 1.0 To: Olivier Certner References: <200507102313.12719.olivier.certner@free.fr> <20050712165530.GA5475@xor.obsecurity.org> <1121189986.6598.1.camel@cream.xbsd.org> <200507130015.31521.olivier.certner@free.fr> In-Reply-To: <200507130015.31521.olivier.certner@free.fr> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sun, 31 Jul 2005 13:21:50 +0000 Cc: freebsd-hackers@freebsd.org, Kris Kennaway , Florent Thoumie Subject: Re: Bug in portupgrade X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2005 02:35:10 -0000 Hello. Olivier Certner wrote: > Le Mardi 12 Juillet 2005 19:39, Florent Thoumie a écrit : > >>Le Mardi 12 juillet 2005 à 12:55 -0400, Kris Kennaway a écrit : >> >>>On Sun, Jul 10, 2005 at 11:13:12PM +0200, Olivier Certner wrote: >>> >>>> Hi, >>>> >>>> There is a bug with portupgrade when it is used to upgrade already >>>>compiled and installed ports for which some dependencies have been >>>>deleted in the package database. This causes a crash in the function >>>>'deorigin' in pkgdb.rb. >>>> >>>> Since I don't know the internals of portupgrade, I don't know if it's >>>>normal to call 'deorigin' with its argument set to nil. If it is, then >>>>the patch below might be useful (beware, I don't know any ruby, I've >>>>just tried something and it works), if it is not, I only can provide >>>>the stack (see below) in order for maintainers to seek the faulty >>>>callers. >>> >>>Please talk to the port maintainer. >> >> Yeah, and good luck :) >> >> Otherwise, he can try to pkgdb -F or remove pkgdb.rb and re-run >> portupgrade. > > > This doesn't work in fact. I'm forwarding these mails to the maintainer. Sorry for my late reply, but would you try out the following patch? Index: lib/portsdb.rb =================================================================== --- lib/portsdb.rb (revision 37) +++ lib/portsdb.rb (revision 38) @@ -846,7 +846,7 @@ def all_depends_list(origin, before_args = nil, after_args = nil) if !before_args && !after_args && i = port(origin) - i.all_depends.map { |n| origin(n) } + i.all_depends.map { |n| origin(n) }.compact else all_depends_list!(origin, before_args, after_args) end