From owner-svn-src-head@freebsd.org Tue Mar 21 01:58:58 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E4EED15CED; Tue, 21 Mar 2017 01:58:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yw0-x236.google.com (mail-yw0-x236.google.com [IPv6:2607:f8b0:4002:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5CE39197B; Tue, 21 Mar 2017 01:58:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yw0-x236.google.com with SMTP id v198so101603406ywc.2; Mon, 20 Mar 2017 18:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jbRus3P+po6n+8Pys+sWnZ+nDOnhUsUTNMfo/cXO3WU=; b=ee2Up5ppI+yTpOEJIt2RT4rjKTOPG0GCK2ObcAP75T8UgTiTriiShR/XZWZWDbSwIe 06O3IJMIT084ylFYcbwTH6UJDqfC6gcN4nHrbnXfiOJu79+PNSSXu/BoJWiZQT0l/UE7 nc2ymBAtKYe3RhqkOXOcQYqEyQDmbhHLmfUDp2yC9k3ASadnLhbFFVyKkFCrsWWDYp+b 51kup7duRZptondl9R3OXw0uPc9/twQn+ITcmfEyuD+jQsemi39sHn5lX2g4i+ouCBYf q5UEDHlu34XoxNATqW4bELT1Jkfdv33z1Oo8m0illRw9hSc2w6vBHLychFzcYyaOHLuC lG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jbRus3P+po6n+8Pys+sWnZ+nDOnhUsUTNMfo/cXO3WU=; b=dYuucPdnqfyEvV2D/EbkPRU7Tzx/7MWnjCdDYfRVk0G1ey3kE8mRuGIP8WmyXKkAXH bNw6DDcccr75cw/e4UWndtCo2lKj1QkQ1XBeJR3iZbonJfVYbTcRAIrvw8Ri41jmRFOE rEijFNWeFX3ttOeY/uat3tjq3z+HSCjJK8ljDn37pNFhcvZv7XmgAkUazknDY4VFCc91 LAvN2Ps4pp0aUwvtvWSJYhfH9NAbM16m7+dKoToWZGOiSn1ReWcg+sGaYtoYP9H6DNWg M8NLIbsMBp8x0OqVLxg8+MFioalKcXGGg4RbI9gJfkrnNLVhTwcoZqipXoFDcrOul1v6 sULg== X-Gm-Message-State: AFeK/H3IJ8pY7VQVL1lIdPmFB8riHXCB40GWgvq7guJ0zn/AHp7vlVaN5vslTE5ZBo5oNnaDTa/nJwTuNY+BRg== X-Received: by 10.37.214.201 with SMTP id n192mr20499075ybg.34.1490061537373; Mon, 20 Mar 2017 18:58:57 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.20.214 with HTTP; Mon, 20 Mar 2017 18:58:56 -0700 (PDT) In-Reply-To: References: <201703202307.v2KN7Y5n071357@repo.freebsd.org> From: Alan Somers Date: Mon, 20 Mar 2017 19:58:56 -0600 X-Google-Sender-Auth: YO_GctajtFXcifrFkhIMHlOPZCQ Message-ID: Subject: Re: svn commit: r315656 - head/tests/sys/netinet To: Ngie Cooper Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 01:58:58 -0000 On Mon, Mar 20, 2017 at 6:55 PM, Ngie Cooper wrote: > On Mon, Mar 20, 2017 at 4:07 PM, Alan Somers wrote: >> Author: asomers >> Date: Mon Mar 20 23:07:34 2017 >> New Revision: 315656 >> URL: https://svnweb.freebsd.org/changeset/base/315656 >> >> Log: >> Fix back-to-back runs of sys/netinet/fibs_test;slaac_on_nondefault_fib6 >> >> This test was failing if run twice because rtadvd takes too long to die. >> The rtadvd process from the first run was still running when the >> second run created its interfaces. The solution is to use SIGKILL during >> the cleanup instead of SIGTERM so rtadvd will die faster. >> >> While I'm here, randomize the addresses used for the test, which makes bugs >> like this easier to spot, and fix the cleanup order to be the opposite of >> the setup order >> >> PR: 217871 >> MFC after: 18 days >> X-MFC-With: 315458 >> Sponsored by: Spectra Logic Corp > > Hi Alan, > I wonder if another seatbelt needs to be added for this scenario > because running a separate copy of rtadvd could adversely affect the > running system behavior... > Thanks, > -Ngie I thought about that, but I decided against it, because rtadvd(8) requires you to specify which interfaces it should operate on, either on the command line or with rtadvctl(8). This test always creates a new interface and only runs rtadvd on the new interface. Also, rtadvd(8) allows you to override the default pidfile, configfile, and socket file, which this test does. So I don't think that the test rtadvd and the system rtadvd can ever affect each other. -Alan