From owner-freebsd-arch@FreeBSD.ORG Wed Sep 7 16:28:16 2005 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9E1416A41F; Wed, 7 Sep 2005 16:28:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2173143D53; Wed, 7 Sep 2005 16:28:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j87GRFXY003660; Wed, 7 Sep 2005 09:27:15 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j87GRC3O003659; Wed, 7 Sep 2005 09:27:12 -0700 (PDT) (envelope-from obrien) Date: Wed, 7 Sep 2005 09:27:12 -0700 From: "David O'Brien" To: Yar Tikhiy Message-ID: <20050907162712.GA3533@dragon.NUXI.org> Mail-Followup-To: obrien@freebsd.org, Yar Tikhiy , Dmitry Pryanishnikov , Poul-Henning Kamp , bug-followup@freebsd.org, freebsd-arch@freebsd.org References: <35184.1125657474@phk.freebsd.dk> <20050905134006.B73214@atlantis.atlantis.dp.ua> <20050907103416.GB91876@dragon.NUXI.org> <20050907124411.GB38943@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050907124411.GB38943@comp.chem.msu.su> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: Dmitry Pryanishnikov , Poul-Henning Kamp , bug-followup@freebsd.org, freebsd-arch@freebsd.org Subject: Re: kern/85503: panic: wrong dirclust using msdosfs in RELENG_6 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2005 16:28:16 -0000 On Wed, Sep 07, 2005 at 04:44:11PM +0400, Yar Tikhiy wrote: > On Wed, Sep 07, 2005 at 03:34:16AM -0700, David O'Brien wrote: > > On Mon, Sep 05, 2005 at 01:50:01PM +0300, Dmitry Pryanishnikov wrote: > > > ftp://external.atlantis.dp.ua/FreeBSD/PR/85503/msdosfs.patch > > > > > > problem has gone away. Please, if possible, review and commit it. I think > > > this > > > patch is a good MFC candidate for RELENG_6 and RELENG_6_0, since it > > > prevents panic in quite common environment. > > > > I've committed it to HEAD. It is up to the RE's to get it into RELENG_6. > > David, I'm afraid there is certain misunderstanding here. First, > the RE team will hardly take care of getting the fix to RELENG_6 > without your initiative. There is zero misunderstanding here. I'm not going to get into a public debate or fight over this. My experiences to date is that it is too much effort to get all but the most critical bug fixes into a frozen branch. Someone else may take up the MFC during the freeze cause. > Second, the PR kern/85503 shouldn't be > closed until the problem is fixed in all relevant branches: It > should be put in the "patched" state instead according to the > project's well-established policy. Thanks. I've been a FreeBSD committer for almost 10 years now - what you claim is "well established" isn't. When a patch from a PR is committed to head the PR may be closed. The new practice of some committers to change the state to patched is something some committers may like to do, but I don't. The same for the MFC reminder and statement in the commit message is also newer thing that some like to use, but I don't. When I am free to commit to a branch and I have the time to adequately test in the branch, I look for all the commits I've done to HEAD, I do a code merge them and MFC them. -- -- David (obrien@FreeBSD.org)