From owner-freebsd-apache@FreeBSD.ORG Mon Feb 24 16:59:14 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 63142849; Mon, 24 Feb 2014 16:59:14 +0000 (UTC) Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com [IPv6:2a00:1450:400c:c00::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4F1031C80; Mon, 24 Feb 2014 16:59:13 +0000 (UTC) Received: by mail-wg0-f46.google.com with SMTP id x13so4834722wgg.25 for ; Mon, 24 Feb 2014 08:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xFZFpgvzEhJuElWEgqJBcZaDpVfsVtoxnNH/GdSRq1c=; b=RnOuEo1Y2lJ6UrG1iuJUyhqdwGDMV0TYuWS3HoSEVRCJRac5ThlDG0YIsujO9B4k2M 8S67nUUGzR6GwYwM7pvZ49N5ZCdYhAPWdiAq0kng1O56IzRKhDaEWqs540X+hQVTc1aW wEjHRtCCzeRkS6T8VqUt2aw78cMy+X/qKQUiIaz1fx+iO98SIAWHYqtqBJhFKfXZyWEh i7s028U/dWNRDIvV4D8nJ6B3JE7N+njxdEdYEH2a2XvUlHd/aO9z1eRB5Df1AQ62fiVQ Y8twiAL29qqnOHMOHaYq9EMYGvBpyWVbsvyD1WZ+hxdZdr4hKeOxLtb5LCMJhBsi4hMC Cr5w== X-Received: by 10.180.187.237 with SMTP id fv13mr15266557wic.26.1393261151606; Mon, 24 Feb 2014 08:59:11 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fo6sm25885728wib.7.2014.02.24.08.59.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 24 Feb 2014 08:59:09 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 24 Feb 2014 17:59:07 +0100 From: Baptiste Daroussin To: Eygene Ryabinkin Subject: Re: Patch for devel/apr1 Message-ID: <20140224165906.GE83610@ithaqua.etoilebsd.net> References: <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net> <0D910641F7C86C422DB65D4C@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Oiv9uiLrevHtW1RS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Mathieu Arnold , Antoine Brodin , apache@freebsd.org, FreeBSD Ports Management Team X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2014 16:59:14 -0000 --Oiv9uiLrevHtW1RS Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 24, 2014 at 08:19:21PM +0400, Eygene Ryabinkin wrote: > Mon, Feb 24, 2014 at 04:43:06PM +0100, Mathieu Arnold wrote: > > +--On 24 f=E9vrier 2014 19:07:49 +0400 Eygene Ryabinkin > > wrote: > > |> and doesn't work for options in a group. > > |=20 > > | Simple fix is attached. > >=20 > > Hum, there can be no simple fix, the reason it is not supported is that > > with that, you can break the port by forcing multiple options where only > > one should be enabled. >=20 > It works for me with OPTIONS_SINGLE of mutt with > {{{ > # Mutt > .if ${.CURDIR:M/usr/ports/mail/mutt} > BATCH=3Dyes > WITH_SCREEN=3Dyes > WITH_NCURSES=3Dyes # SCREEN: single > WITH_SLANG=3Dyes # SCREEN: single > WITH_COMPRESSED_FOLDERS=3Dyes > WITHOUT_DEBUG=3Dyes > WITHOUT_FLOCK=3Dyes > WITH_GPGME=3Dyes > WITHOUT_GREETING_PATCH=3Dyes > WITHOUT_HTML=3Dyes > WITH_ICONV=3Dyes > WITHOUT_IDN=3Dyes > WITH_IFDEF_PATCH=3Dyes > WITHOUT_IMAP_HEADER_CACHE=3Dyes > WITH_LOCALES_FIX=3Dyes > WITH_MAILBOX_MANPAGES=3Dyes > WITH_MAILDIR_HEADER_CACHE=3Dyes > WITH_MAILDIR_MTIME_PATCH=3Dyes > WITHOUT_NNTP=3Dyes > WITHOUT_PARENT_CHILD_MATCH_PATCH=3Dyes > WITH_QUOTE_PATCH=3Dyes > WITH_REVERSE_REPLY_PATCH=3Dyes > WITH_SASL=3Dyes > WITHOUT_SGMLFORMAT=3Dyes > WITHOUT_SIDEBAR_PATCH=3Dyes > WITHOUT_SIGNATURE_MENU=3Dyes > WITH_SMIME_OUTLOOK_COMPAT=3Dyes > WITH_SMTP=3Dyes > WITH_TOKYOCABINET=3Dyes > WITHOUT_TRASH_PATCH=3Dyes > WITHOUT_XML=3Dyes > WITHOUT_ASPELL=3Dyes > WITHOUT_ISPELL=3Dyes > .endif > }}} > I have the proper error, > {{{ > $ make > =3D=3D=3D=3D> You must select one and only one option from the SCREEN sin= gle > make: exec(exit) failed (No such file or directory) > *** Error code 1 >=20 > Stop. > }}} >=20 > > I've just committed a patch to bsd.options.mk[1] so that it tells > > you you are using an old way and should update. >=20 > Well, while this can have its own merits, it is a way too many POLA > changes and sudden hickups (iconv in base, this change, ld's > --add-needed change) that make me to collide my head and the > table/wall. >=20 You cannot call POLA on something new OPTIONS_GROUP, OPTIONS_RADIO, OPTIONS_SINGLE, OPTIONS_MULTI are new the maintainer as decided to use the = new interfaces because they are more convenient. The old option framework as moved to OPTIONS_DEFINE and thus we maintain compatibility for this change (hence the WITH/WITHOUT thing working properly with OPTIONS_DEFINE options). All you used to manually do via .if ${.CURDIR...} can be intrument a reliab= le way with the new option framework directly and it will work with all OPTION= S_* things: mail_mutt_SET=3D TOKYOCABINET GPGME mail_mutt_UNSET=3D ASPELL ISPELL OPTIONS_SET will make it global and it can be overwritten by the specifion: __SET same goes for unset. regards, Bapt --Oiv9uiLrevHtW1RS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlMLeloACgkQ8kTtMUmk6EwxzACfdCarEJKvU2qlJ51xcYHXGDqR c/MAoIbZ5dw6hbmr7TTGSEUR6OGi6mL1 =BV+n -----END PGP SIGNATURE----- --Oiv9uiLrevHtW1RS--