From owner-svn-src-projects@freebsd.org Fri Mar 15 19:22:53 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED35D152C53A for ; Fri, 15 Mar 2019 19:22:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E7C0E77901; Fri, 15 Mar 2019 19:22:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x2FJMjQp088802 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 15 Mar 2019 21:22:48 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x2FJMjQp088802 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x2FJMjNQ088801; Fri, 15 Mar 2019 21:22:45 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 15 Mar 2019 21:22:45 +0200 From: Konstantin Belousov To: Alan Somers Cc: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r345198 - projects/fuse2/share/man/man9 Message-ID: <20190315192245.GD96870@kib.kiev.ua> References: <201903151850.x2FIoas1001666@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201903151850.x2FIoas1001666@repo.freebsd.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 19:22:53 -0000 On Fri, Mar 15, 2019 at 06:50:36PM +0000, Alan Somers wrote: > Author: asomers > Date: Fri Mar 15 18:50:36 2019 > New Revision: 345198 > URL: https://svnweb.freebsd.org/changeset/base/345198 > > Log: > VOP_INACTIVE(9): clarify wording > > Reviewed by: kib, 0mp > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D19596 > > Modified: > projects/fuse2/share/man/man9/VOP_INACTIVE.9 > > Modified: projects/fuse2/share/man/man9/VOP_INACTIVE.9 > ============================================================================== > --- projects/fuse2/share/man/man9/VOP_INACTIVE.9 Fri Mar 15 18:50:00 2019 (r345197) > +++ projects/fuse2/share/man/man9/VOP_INACTIVE.9 Fri Mar 15 18:50:36 2019 (r345198) > @@ -28,7 +28,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd July 27, 2014 > +.Dd March 15, 2019 > .Dt VOP_INACTIVE 9 > .Os > .Sh NAME > @@ -50,13 +50,16 @@ The vnode being reclaimed. > .El > .Pp > .Fn VOP_INACTIVE > -is called when the kernel is no longer using the vnode. > +is usually called when the kernel is no longer using the vnode. > +However, there is no guarantee that it will be called at all, for example if > +the last reference was dropped while the vnode lock could not be upgraded > +to exclusive without sleeping. > This may be > because the reference count reaches zero or it may be that the > file system is being forcibly unmounted while there are open files. > -It can be used to reclaim space for > +It can be used to reclaim space on the last close of an > .Sq open but deleted > -files. > +file. > .Pp > .Fn VOP_RECLAIM > is called when a vnode is being reused for a different file system. Why did you committed to the branch ? I do not think it is on-topic there, and would like to see the wording fixes propagated back to stable branches. I.e. even if you merge this to HEAD in some future, I do not think it is easy to merge to stable-XX from there as part of the large commit.