From owner-freebsd-hackers Thu Mar 14 5: 4:41 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from patrocles.silby.com (d12.as13.nwbl0.wi.voyager.net [169.207.135.140]) by hub.freebsd.org (Postfix) with ESMTP id E4EDF37B41A for ; Thu, 14 Mar 2002 05:04:35 -0800 (PST) Received: from patrocles.silby.com (localhost [127.0.0.1]) by patrocles.silby.com (8.12.2/8.12.2) with ESMTP id g2E79SjJ023508; Thu, 14 Mar 2002 07:09:28 GMT (envelope-from silby@silby.com) Received: from localhost (silby@localhost) by patrocles.silby.com (8.12.2/8.12.2/Submit) with ESMTP id g2E79MGD023505; Thu, 14 Mar 2002 07:09:26 GMT X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs Date: Thu, 14 Mar 2002 07:09:22 +0000 (GMT) From: Mike Silbersack To: Terry Lambert Cc: "Clark C . Evans" , Subject: Re: panic: pmap_enter In-Reply-To: <3C8E825E.41E7DDFA@mindspring.com> Message-ID: <20020314070732.H23489-100000@patrocles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 12 Mar 2002, Terry Lambert wrote: > #define blkmap(fs, map, loc) \ > (((map)[(loc) / NBBY] >> ((loc) % NBBY)) & (0xff >> (NBBY - (fs)->fs_frag))) > > looks a little suspect, doesn't it? "& 0" for 8 is probably > correct, but "& 1" for 4 and "& 2" for 2 and "& 4" for 1 is > probably not right... maybe: > > #define blkmap(fs, map, loc) \ > (((map)[(loc) / NBBY] >> ((loc) % NBBY)) & 0xff & ((0xff >> (NBBY - > (fs)->fs_frag))^0xff)) > > Would be more right? After all, it's the high bits of the low > bits you want to save, not the low bits of the low bits... > > -- Terry FWIW, I didn't mean to ignore this message, I was going to look it over carefully before commenting. However, Sid Meier told me that I needed to spend some time taking over the world, so I was unable to. If anyone familiar with FFS wants to check it out, please be my guest, otherwise I'll try to get to it soon. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message