From nobody Mon Aug 3 15:06:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hDKlK4Nfwz6mKHG for ; Mon, 03 Aug 2026 15:06:53 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-21.consmr.mail.gq1.yahoo.com (sonic301-21.consmr.mail.gq1.yahoo.com [98.137.64.147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4hDKlK0LDdz46PF for ; Mon, 03 Aug 2026 15:06:52 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785769610; bh=/IHS+3WjvH/9Ht8OAkNZ1Msj3WVFY1ra9HnA6RnnDEU=; h=Date:Subject:To:References:From:In-Reply-To:From:Subject:Reply-To; b=F7T+4sm3injbtTt1eUIjT9S7122luhUj0zKV95NHp5ukUwPHy+juXGFaAjLS4xlUpD1pGxvOuuvvtoGfbIStVlRzvwgfJj7A/nEjurQujVQaDpf7EgxmWwtAOqMtOJdk38rwit1eZ6ZMQdWc6dAmxBg7AmLuiZw5/TD2mCE8iJroedcJJkYA0fnBNBwNnUDLZAXaXPwsENA83d3sTUc3/m5nsKW0pL+ueMId5c4ON+yi/Oqox0UMVBJF34omYW74OR+J7y+a3fwIUS3HzQNdo5ftb+sIrL3RF6irL4fpfrVtccPVs+oFs2l8Diht2yNHw2asgtNNm/NMo2C4pGjkJA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785769610; bh=tz1uW3JCs23ABVUp7lVG3B3bWyKiChjzyK02HkJpD+p=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=t98hd5wYdsS/C2YWQkZpTpFEMInxaWUKuRIJF+VouElaoJlJ/dkJJra859uEr+DFgIFiplXgY48943DCkTgrq0hu9uyVDTA3eyMIZTmF9M0dpetKpDPiTBQomniGimLHv7JCsaDNGzPmrIU7KxlNlIHfozlNmzefIkC/GdwbZ/ZSotB9v52VDcpButDTHIoIem6nfsncPbaaShhLaoS/piQ27PyweZueYTKv7dPC7Geba+t26JRqxSFNDmhEctULTr0i1bESEztiXZthUJq1JK9AWA93/ITnqPH0BUpJYiwX3aK1mjZbZuQZemkZm2YRLU/jL9FNqNRp+RQPqnC47w== X-YMail-OSG: VY3CnfoVM1l8avkYdmgdWHN1izJilfm8sap9P0nb.JPJ.WITaRJYYCSap53ybvl JT7fXyRasebsndi..EuRjSdsdsJHQTuInW_qhXMtpHO6Kp8De91zcAZQ5amd4zgNgThL74ULd1On m_LDEZBc0qpKPpncyHciYLOv_HM7Sr_o.y9KBZHZ5QEvGw6QlFte7snOuLy8zyCm_Qm4b0YAdp_c gFzt60rtcUrLoJuhzsqMNH3.lXNu3J5fuMq5WpZuKwOhYtJbMqfEaDKkEHL.Ah3GtNkvh_fpcDUo NyJ3iCu_GfmN31yMSQxGujNrvErrJVOazbrcP9coZXnT.YORudOfQE6y2h6JbhM8jGuRni5P5AUe YpTNXnJq5CN16HXzOkxHUaLsNpO9BnKPzPA5H0SfNmaZm7_fFMvPGTe0bZOd1cjTRPdm_i06_udW vNCr7VeHLMBBS_5JsO2XhU3XU.PQFTjLU7NLZ6_s9fW0RM3f8ypAzUTTmUCKfwxfEJT2i4jLc4ex B15pT5OuMSDKWtaXuS3s_loBwA_KcQk_oi6SrVftRM5eo0dwMPvgvnYX.WcImekzmp0T2IbNdZXJ 9IDCm8ji1dVD1cNtWqzAD3oh8QYfrFZyTl9DNVoXzgk98ZSCQ9qiC8ZfGA5dYUb1a7uE7fvnTwxm 1W1pTjmUnJinMRlsZ9djeHEUlLHNzxa7B780.DOxY2GwplOjTi.DpInVmQB7ob1DK5Vjtt3Xe1Jg sfEEVDvxfxCmgjCf_kxKDi4Mr1AxtD2OFxJv9Jn0S9KC2jGRDlvX1I2LiEP.XNquPnLs.aRVGSmI pbqPUMZRMMe8dgRa1KRF1ZeQHy3QtkzaLsuvo5JgTUYqmCEN2HbSS4G8bvT755XSSzCLKQAXyW2J EgY2HVa2Ylrp70olxvNcGXPp3CE7_ss6r3Y0cAdpOe8jLvjSKCfOqIPxL66GZhIQenWjmgDrERGX f3E.K.3_oF4Fg0MpS6gbQGb1myQA0pPQPf.QEOjZ1VAqdMBCRXWCSWFOQghOFpqzPAlpZML5aIhc OXgVDvQo2T9geb0PG1bUjvZfI9OmGGGuowggvbncXF_Wikr_fBmuQk.EAx3S3UdVpgZUL7UcAoyc vmwnDFBQlrM4fQYgYnjs4Z_Oeuoh9WISr3ZK881HsUPps2ieHlnvjqRUNi6f5jpAV7WFbT.l4D0I 4.Pho.yg1Mgj_KeBA8U6ryBnSj1EucBoJDBoy5qbDPTTiRjLuAh1rYhYfuaS66nkBZon1_P5w9UA 27pVDtdrdkVBKNEOB3ogt_FM6mBnEgoCvnPt1Tf7bwMPH1NVokyJEIX4a_cWPU41HJ8tptbSGI3V vxcDieVCDNo7efSKi1ce4WCWAmBk1RRS3cn3t2f7N2rPjnwv4aT.cuFgxHNB2eKi1xahaXOyZlJN 524ux_._VSPwrChb3iPdZbJwa6EU_W9btrNX4gs882MVyMSepC3Dk74de78mJOXenvHO3nPTsI5l AIfnpuDEY_3_DZtxmNnK9Lxe6xm5HnXiwOQ3ohsd3DefnGEActqAXRIR.qbMGkjf0BwsOpp9g4uW B.B0l1Db.gHySVhFq4I1lInWg4e1ixfhhoH7NWj12fouSKV7Y846mCwBYN1m8HcLXIcN6kp5mhDX X7qasx4bel1Y9Wk6Es.oocpe4uDTv1.apD5cDytu6D9PkhIe3bMkww1eRPd0VK9N9FXRsJmqqQYu eCX21A9cBJ9w8s6Coqb14dMS2xzvoIq8LWdxHSQbm0wgepSjzH86lNSm5uNfSNAsFEFb9f.XHHKO J1olUypmJFwkgbf_xLYz.CfUQHWIo5NSSlcv3aspROGIGh03AIUBbpEqp.ZLarvWBBGfAZ_3fcm2 SgvtaY.0_8d9HKO83IFMQKUZ.m1clWssJBUfJezhfYy4Vu4.e7v9OoK665raz0TOtrxoETbO1XdF jF1cIYeWqbnqU5KVWWqPSrWes208URPqA.w.dWlUxSqrdwRAVFoKY9rd0TqDwA72BPw7ktS65oEW xMsnhGmimVXfTQSMbKeZzkbYfsDLD18pbYxO6002lJtk2BEEv1nDT9ALu3GYH3jjzBV_w.bQlwpn S4uS8kJXIN.ZKllJkKeR3iaskCvvOvso6ct88UE0_ampyT2hleS_SSUxl6yrC8o4zsEQJ16z_hh8 xPfuDixRNzKimFmVnmI.rnEa4ZxkbtvIQvreBB5H5v8uzyMJ2IVBWOVNytarH5ndBCfcz4Ngt6cM XPB5z9j_qiVKhOIO8Zqshok2zqKvfYDnT17Bn2S1vySGKIm1qVTmJi_C9hjzvaL_4aQGOwYAeQ6A .p0w4GwakMj42_WcAC0.9eCquHu4g2jXkSD5tTUx9AH0SGmsYcefIg8hbT5wsphk8Aw-- X-Sonic-MF: X-Sonic-ID: f5538c96-b5d3-4416-b163-039af6a7940c Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Mon, 3 Aug 2026 15:06:50 +0000 Received: by hermes--production-gq1-7749664df-bbhqk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 020cd13a1503491902ce5867ce60059a; Mon, 03 Aug 2026 15:06:48 +0000 (UTC) Message-ID: <20f9a785-a057-4303-a844-6b30930c7ac0@yahoo.com> Date: Mon, 3 Aug 2026 08:06:48 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f1d98862044f - main - libc: getopt{,_long}: Const correctness for C23 To: Lexi Winter , dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a70a610.37a4b.9b19e8a@gitrepo.freebsd.org> Content-Language: en-US From: Mark Millard In-Reply-To: <6a70a610.37a4b.9b19e8a@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.26215 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Rspamd-Queue-Id: 4hDKlK0LDdz46PF X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Spamd-Bar: ---- On 8/3/26 07:30, Lexi Winter wrote: > The branch main has been updated by ivy: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f1d98862044f7748c6f930e9d4339abc166a5b16 > > commit f1d98862044f7748c6f930e9d4339abc166a5b16 > Author: Lexi Winter > AuthorDate: 2026-08-03 14:02:51 +0000 > Commit: Lexi Winter > CommitDate: 2026-08-03 14:02:51 +0000 > > libc: getopt{,_long}: Const correctness for C23 > > On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr() > now implements the C23 behaviour where passing a const pointer to > strchr() also returns a const pointer. A note on the terminology in this and the related commits: "const char *NAME;" is a (non-const) pointer to a const char, not a const pointer to a (non-const) char. In short: pointer to const is now being put to use, not const pointer. > This breaks getopt during > the bootstrap build, since it assumes the return value is always > a mutable pointer. > > Since the pointed-to value is never modified, fix this by making > the pointer const. > > MFC after: 1 week > Reviewed by: emaste > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D58488 > --- > lib/libc/stdlib/getopt.c | 2 +- > lib/libc/stdlib/getopt_long.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/libc/stdlib/getopt.c b/lib/libc/stdlib/getopt.c > index 2b5e3fa69032..e1edc5a3ee83 100644 > --- a/lib/libc/stdlib/getopt.c > +++ b/lib/libc/stdlib/getopt.c > @@ -57,7 +57,7 @@ int > getopt(int nargc, char * const nargv[], const char *ostr) > { > static char *place = EMSG; /* option letter processing */ > - char *oli; /* option letter list index */ > + const char *oli; /* option letter list index */ > > if (optreset || *place == 0) { /* update scanning pointer */ > optreset = 0; > diff --git a/lib/libc/stdlib/getopt_long.c b/lib/libc/stdlib/getopt_long.c > index 5cf6a55649bd..99be520fe332 100644 > --- a/lib/libc/stdlib/getopt_long.c > +++ b/lib/libc/stdlib/getopt_long.c > @@ -349,7 +349,7 @@ static int > getopt_internal(int nargc, char * const *nargv, const char *options, > const struct option *long_options, int *idx, int flags) > { > - char *oli; /* option letter list index */ > + const char *oli; /* option letter list index */ > int optchar, short_too; > static int posixly_correct = -1; > > > -- === Mark Millard marklmi at yahoo.com