From owner-p4-projects@FreeBSD.ORG  Sat Jan  6 14:40:33 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 92E1116A510; Sat,  6 Jan 2007 14:40:33 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7013716A506;
	Sat,  6 Jan 2007 14:40:33 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])
	by mx1.freebsd.org (Postfix) with ESMTP id 039D213C46C;
	Sat,  6 Jan 2007 14:40:32 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.8/8.13.7) with ESMTP id l06EeUd2001558
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 6 Jan 2007 15:40:30 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.8/8.13.3/Submit) id l06EeUGi001557;
	Sat, 6 Jan 2007 15:40:30 +0100 (CET)
Date: Sat, 6 Jan 2007 15:40:30 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20070106144030.GB1353@stud.fit.vutbr.cz>
References: <200701050802.l0582Gnq067583@repoman.freebsd.org>
	<200701051232.28019.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200701051232.28019.jhb@freebsd.org>
User-Agent: Mutt/1.4.2.2i
X-Scanned-By: MIMEDefang 2.57 on 147.229.176.14
Cc: Roman Divacky <rdivacky@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 112535 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Jan 2007 14:40:33 -0000

On Fri, Jan 05, 2007 at 12:32:27PM -0500, John Baldwin wrote:
> On Friday 05 January 2007 03:02, Roman Divacky wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=112535
> > 
> > Change 112535 by rdivacky@rdivacky_witten on 2007/01/05 08:01:24
> > 
> > 	No need to lock prison in a case of linux_use26 becuase the int
> > 	setting is atomic and process cannot leave jail.
> > 	
> > 	Submitted by: kib
> > 	Reviewed by: jhb
> > 
> > Affected files ...
> > 
> > .. //depot/projects/linuxolator/src/sys/compat/linux/linux_mib.c#6 edit
> > 
> > Differences ...
> > 
> > ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_mib.c#6 
> (text+ko) ====
> > 
> > @@ -237,12 +237,10 @@
> >  
> >  	pr = td->td_ucred->cr_prison;
> >  	if (pr != NULL) {
> > -		mtx_lock(&pr->pr_mtx);
> >  		if (pr->pr_linux != NULL) {
> >  			lpr = (struct linux_prison *)pr->pr_linux;
> >  			use26 = lpr->pr_use_linux26;
> >  		}
> > -		mtx_unlock(&pr->pr_mtx);
> >  	} else
> >  		use26 = linux_use_linux26;
> >  	
> > 
> 
> Hmm, what is use26 set to if pr != NULL but pr->pr_linux == NULL?

to the default value of 0