From owner-freebsd-bugs@FreeBSD.ORG  Mon Sep 13 05:35:22 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A35D516A4CE
	for <freebsd-bugs@freebsd.org>; Mon, 13 Sep 2004 05:35:22 +0000 (GMT)
Received: from rosebud.otenet.gr (rosebud.otenet.gr [195.170.0.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D12B243D58
	for <freebsd-bugs@freebsd.org>; Mon, 13 Sep 2004 05:35:21 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from gothmog.gr (patr530-a201.otenet.gr [212.205.215.201])
	i8D5ZI2F002820;	Mon, 13 Sep 2004 08:35:19 +0300
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.13.1/8.13.1) with ESMTP id i8D5XDZN031648;
	Mon, 13 Sep 2004 08:33:13 +0300 (EEST)
	(envelope-from keramida@freebsd.org)
Received: (from giorgos@localhost)
	by gothmog.gr (8.13.1/8.13.1/Submit) id i8D5XDHN031647;
	Mon, 13 Sep 2004 08:33:13 +0300 (EEST)
	(envelope-from keramida@freebsd.org)
Date: Mon, 13 Sep 2004 08:33:13 +0300
From: Giorgos Keramidas <keramida@freebsd.org>
To: Dan Lukes <dan@obluda.cz>
Message-ID: <20040913053313.GA31577@gothmog.gr>
References: <200409120237.i8C2bb7V007096@kulesh.obluda.cz>
	<20040912183535.GE1047@gothmog.gr> <20040913033216.K77141@ns.obluda.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040913033216.K77141@ns.obluda.cz>
cc: freebsd-bugs@freebsd.org
Subject: Re: bin/71618: [PATCH] cleanup of the usr.sbin/timed code
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Sep 2004 05:35:22 -0000

On 2004-09-13 03:37, Dan Lukes <dan@obluda.cz> wrote:
>On Sun, 12 Sep 2004, Giorgos Keramidas wrote:
>> [...] can you try the following (and see if you can come up with
>> fixes for the warnings this shows)?
>>
>>	# cd /usr/src/usr.sbin/timed/
>>	# make NO_WERROR=1 WARNS?=3
>
> 	I'm compiling with -Wall -O3.
> 	It seems to be more than any WARNS=X

AFAIK -O3 is a bit unsafe in FreeBSD.  I know that some warnings don't
work correctly in GCC though, so `-O -Wall' shoule be fine most of the
time.  To be sure I have to check with teh manual of GCC to see if this
has changed in 3.4.x versions though.

WARNS=1 includes -Wall, so you're fine with just WARNS=1.  Higher levels
of WARNS enable other sorts of warnings too.  The file bsd.sys.mk in
/usr/share/mk contains the exact set of these options, i.e. WARNS=3 is
equivalent to:

    CFLAGS="-Wall -Wno-format-y2k -Wreturn-type -Wcast-qual \
	-Wwrite-strings -Wswitch -Wshadow -Wcast-align"

> If there are some warning not corrected by attached patches, then it
> mean I'm don't know how the good way to correct it.

Yeah, it makes sense :)

Regards,
Giorgos