From owner-svn-ports-head@FreeBSD.ORG Fri Feb 21 19:30:10 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 945588B0; Fri, 21 Feb 2014 19:30:10 +0000 (UTC) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A6F171396; Fri, 21 Feb 2014 19:30:09 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id cc10so1197537wib.10 for ; Fri, 21 Feb 2014 11:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=QktFSRwELpcYhBvdtOc4We3jGK9veWAdQT2su3QhNWE=; b=iqkJPQiPf2CDNS6OdnFHqRWrvRMXBA3xgQVlFYGSDJtOgSIenkCpmInNULwwrUbkef R3fAivZpWTGUs9gwj5MXKtnT+dojx/hvFmz7BhtdIGloAo4v2lPdJXo2vqcAWPE4xfFN rF4FgJIu7jklcGsLUnfxqIYNOcKMppTqpTYh0EtDh5vliKTJShBIX/hVknNt+wG45zIv Ff1WXJD51DR+7HWRvv2wyf69joLPYG8wKMC07XpVhE5FY79gXy4huUGhVKYDL3vlLF9r /YnOvob8A5qqIbVFcUMwBK3YjRiyeIFmELXgeAak4Vuozb2n+Lvarrg3kx4rteWDnSVu kOoQ== X-Received: by 10.195.13.234 with SMTP id fb10mr8727067wjd.50.1393011007953; Fri, 21 Feb 2014 11:30:07 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id d6sm10309049wic.9.2014.02.21.11.30.06 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 21 Feb 2014 11:30:06 -0800 (PST) Sender: Baptiste Daroussin Date: Fri, 21 Feb 2014 20:30:04 +0100 From: Baptiste Daroussin To: Tijl Coosemans Subject: Re: svn commit: r345514 - head/Mk/Uses Message-ID: <20140221193004.GM1699@ithaqua.etoilebsd.net> References: <201402211647.s1LGlTuw053335@svn.freebsd.org> <20140221194949.29595e47@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NZtAI5QFBF0GmLcW" Content-Disposition: inline In-Reply-To: <20140221194949.29595e47@kalimero.tijl.coosemans.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Feb 2014 19:30:10 -0000 --NZtAI5QFBF0GmLcW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 21, 2014 at 07:49:49PM +0100, Tijl Coosemans wrote: > On Fri, 21 Feb 2014 16:47:29 +0000 (UTC) Baptiste Daroussin wrote: > > Author: bapt > > Date: Fri Feb 21 16:47:29 2014 > > New Revision: 345514 > > URL: http://svnweb.freebsd.org/changeset/ports/345514 > > QAT: https://qat.redports.org/buildarchive/r345514/ > >=20 > > Log: > > libtool 1.4.2a was defining the shared extension as shrext_cmds, rena= me it shared_ext > > like in newer libtool so the rest of USES=3Diconv magic just works > >=20 > > Modified: > > head/Mk/Uses/libtool.mk > >=20 > > Modified: head/Mk/Uses/libtool.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/Mk/Uses/libtool.mk Fri Feb 21 16:04:38 2014 (r345513) > > +++ head/Mk/Uses/libtool.mk Fri Feb 21 16:47:29 2014 (r345514) > > @@ -22,7 +22,8 @@ patch-libtool: > > -e '/link_all_deplibs[0-9A-Z_]*=3D/s/=3Dunknown/=3Dno/' \ > > -e '/objformat=3D/s/echo aout/echo elf/' \ > > -e "/freebsd-elf\\*)/,/;;/ { \ > > - /deplibs_check_method=3D/s/=3D.*/=3Dpass_all/; }" > > + /deplibs_check_method=3D/s/=3D.*/=3Dpass_all/; }" \ > > + -e "s/shrext_cmds/shared_ext/g" > > =20 > > .if ! ${libtool_ARGS:Moldver} > > @${FIND} ${WRKDIR} \( -name configure -or -name ltconfig \) \ >=20 > Both shrext_cmds and shared_ext exist so I'm not sure it's safe to use > only one name. shrext_cmds is defined by configure (normally just .so > for us) or by libtool when invoked with -shrext some_extension. Then > later libtool defines shared_ext using 'eval shared_ext=3D\"$shrext_cmds\= "'. >=20 > What port does this fix? devel/libghthash is the port broken if you end up with a better fix, please= just commit. Thank you Bapt --NZtAI5QFBF0GmLcW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlMHqTwACgkQ8kTtMUmk6Ey6UwCffMeE3ieFfA8a2mW0+kL7nesA IrQAnAnciUsnmr3LQDv9SpVCT3WpJ+q0 =MwRB -----END PGP SIGNATURE----- --NZtAI5QFBF0GmLcW--