From owner-svn-src-all@FreeBSD.ORG Sat Jan 1 22:18:36 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 206B5106566C; Sat, 1 Jan 2011 22:18:36 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B57FF8FC14; Sat, 1 Jan 2011 22:18:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id p01MCPXE043178; Sat, 1 Jan 2011 15:12:25 -0700 (MST) (envelope-from imp@bsdimp.com) Message-ID: <4D1FA6C9.2040309@bsdimp.com> Date: Sat, 01 Jan 2011 15:12:25 -0700 From: Warner Losh User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6 MIME-Version: 1.0 To: Jilles Tjoelker References: <201012301806.oBUI6VcW046731@svn.freebsd.org> <20101231144308.GA55052@stack.nl> <4D1E51BD.8090707@bsdimp.com> <20110101145734.GA72435@stack.nl> In-Reply-To: <20110101145734.GA72435@stack.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek Subject: Re: svn commit: r216823 - head/sbin/shutdown X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jan 2011 22:18:36 -0000 On 01/01/2011 07:57, Jilles Tjoelker wrote: > On Fri, Dec 31, 2010 at 02:57:17PM -0700, Warner Losh wrote: >> On 12/31/2010 07:43, Jilles Tjoelker wrote: >>> On Thu, Dec 30, 2010 at 06:06:31PM +0000, Pawel Jakub Dawidek wrote: >>>> Author: pjd >>>> Date: Thu Dec 30 18:06:31 2010 >>>> New Revision: 216823 >>>> URL: http://svn.freebsd.org/changeset/base/216823 >>>> Log: >>>> For compatibility with Linux and Solaris add poweroff(8). >>>> It is implemented as a hard link to shutdown(8) and it is equivalent of: >>>> # shutdown -p now >>> If we go that way, then for consistency reboot(8) and halt(8) should >>> also be equivalent to calling shutdown -r now and shutdown -h now >>> respectively, unless conflicting options are given. Linux has a -f >>> option for what's currently reboot's and halt's default action, and >>> fastboot(8)/fasthalt(8) could also retain the current behaviour. >>> I would be in favour of this change. >> I'm not sure I'd go this far. I really *LIKE* that halt/reboot is the >> low-level interface that shutdown -r now calls. I'm not sure that >> moving away from this would be a good idea. It cuts out many levels of >> indirection that can be useful in many instances. > But that's not how it works. After printing all the warnings, > shutdown(8) signals init. Ctrl+Alt+Del also signals init (and that's > nontrivial to change, because it's in the kernel). > > Only if the strange -o option is used does shutdown execute reboot(8) or > halt(8). > > I think the canonical low-level interface should be sending signals to > init. reboot(8) and halt(8) doing things on their own should be banished > to non-default options. (Something should be fixed first so that > /etc/rc.d/mixer doesn't destroy the user's settings from single-user > mode.) I still strongly disagree with this change, however, the proper place to talk about it is on arch@. reboot and halt purposely stop init, kill everything and call reboot. That's what I mean that they are a lower-level interface than shutdown, which signals init to do its more complicated, higher level thing asyncrhonously in the background... Warner