From owner-cvs-all  Tue Dec 31 13:23:12 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E1A2837B401; Tue, 31 Dec 2002 13:23:10 -0800 (PST)
Received: from lysimachus.hosting.swbell.net (lysimachus.hosting.swbell.net [216.100.98.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DEBB643EB2; Tue, 31 Dec 2002 13:23:09 -0800 (PST)
	(envelope-from alc@imimic.com)
Received: from imimic.com (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18])
	by lysimachus.hosting.swbell.net
	id QAA21876; Tue, 31 Dec 2002 16:23:02 -0500 (EST)
	[ConcentricHost SMTP Relay 1.14]
Message-ID: <3E120AAF.539CB4F1@imimic.com>
Date: Tue, 31 Dec 2002 15:22:55 -0600
From: "Alan L. Cox" <alc@imimic.com>
Organization: iMimic Networking, Inc.
X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Nate Lawson <nate@root.org>
Cc: Alan Cox <alc@FreeBSD.org>, cvs-all@freebsd.org,
	cvs-committers@freebsd.org
Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h
References: <Pine.BSF.4.21.0212311312480.90110-100000@root.org>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Nate Lawson wrote:
> 
> On Tue, 31 Dec 2002, Alan Cox wrote:
> >   Modified files:
> >     sys/vm               vm_map.c vm_map.h
> >   Log:
> >   Implement a variant locking scheme for vm maps: Access to system maps
> >   is now synchronized by a mutex, whereas access to user maps is still
> >   synchronized by a lockmgr()-based lock.
> >
> >   Revision  Changes    Path
> >   1.278     +38 -16    src/sys/vm/vm_map.c
> >   1.94      +1 -0      src/sys/vm/vm_map.h
> >
> > +             _mtx_lock_flags(&map->system_mtx, 0, file, line);
> > +     else {
> > +             error = lockmgr(&map->lock, LK_EXCLUSIVE, NULL, curthread);
> > +             KASSERT(error == 0, ("%s: failed to get lock", __func__));
> > +     }
> > [...]
> > -     lockmgr(&map->lock, LK_RELEASE, NULL, curthread);
> > +     if (map->system_map)
> > +             _mtx_unlock_flags(&map->system_mtx, 0, file, line);
> > +     else
> > +             lockmgr(&map->lock, LK_RELEASE, NULL, curthread);
> >  }
> >
> >  void
> 
> Please use the non-underscore, exported mtx_* routines.  The macros expand
> to the same thing unless you're doing something strange w/ file and line
> (but I don't see that in your patch).
> 

Yes, they expand to rather useless information: line X of _vm_map_lock. 
As I've written it, any messages will report the call site of
_vm_map_lock, which is what we want to know.

Alan

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message