Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Feb 2023 23:01:23 +0100
From:      Moin Rahman <bofh@freebsd.org>
To:        Antoine Brodin <antoine@FreeBSD.org>
Cc:        "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "dev-commits-ports-all@freebsd.org" <dev-commits-ports-all@freebsd.org>, "dev-commits-ports-main@freebsd.org" <dev-commits-ports-main@freebsd.org>
Subject:   Re: git: 1c1e0975ade6 - main - databases/mysql-connector-odbc: remove expired port
Message-ID:  <F8E09111-EEF6-402C-8D22-DC1A6AE9D78F@freebsd.org>
In-Reply-To: <CAALwa8kEgi353Wg6Q2r22roCVeOZwOwDZMYNUKbZuCzfJj%2B8TA@mail.gmail.com>
References:  <202302182007.31IK7JWK071189@gitrepo.freebsd.org> <B314D9F6-D986-455B-8FFC-8ECCBF8A262B@freebsd.org> <CAALwa8kEgi353Wg6Q2r22roCVeOZwOwDZMYNUKbZuCzfJj%2B8TA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_210622DF-0315-4905-B7F3-4AB23EAA2E67
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Unless you are confused or watching the logs of mysql exp-run for =
changing the default version this is not correct.

Just for the sake of the conversation I have rebuilt the ports with now =
mysql 5.7 as default and here are the results:
=
https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc=
-mysql57/5.3.14/123-default.log
=
https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc=
-mysql57/5.3.14/123i386-default.log
=
https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc=
-mysql57/5.3.14/131-default.log

And neither do I see any PKGBASE conflicts:
cd databases/mysql-connector-odbc && make -v PKGBASE
cd databases/mysql-connector-odbc-80 && =
mysql-connector-odbc-unixodbc-mysql57
make -v PKGBASE
mysql-connector-odbc-unixodbc-mysql80

Please revert.

Kind regards,
Moin

> On Feb 18, 2023, at 9:40 PM, Antoine Brodin <antoine@FreeBSD.org> =
wrote:
>=20
> On Sat, Feb 18, 2023 at 8:16 PM Moin Rahman <bofh@freebsd.org> wrote:
>>=20
>> Why did you expire this port? This is marked to expire on 2012-12-31.
>=20
> It has not been built for months (ignored) and its PKGBASE now
> collides with mysql-connector-odbc-80.
>=20
> Antoine
>=20
>> On Feb 18, 2023, at 9:07 PM, Antoine Brodin <antoine@FreeBSD.org> =
wrote:
>>=20
>> The branch main has been updated by antoine:
>>=20
>> URL: =
https://cgit.FreeBSD.org/ports/commit/?id=3D1c1e0975ade679a1f13c10709cf443=
bc82dde3b9
>>=20
>> commit 1c1e0975ade679a1f13c10709cf443bc82dde3b9
>> Author:     Antoine Brodin <antoine@FreeBSD.org>
>> AuthorDate: 2023-02-18 20:06:29 +0000
>> Commit:     Antoine Brodin <antoine@FreeBSD.org>
>> CommitDate: 2023-02-18 20:06:29 +0000
>>=20
>>   databases/mysql-connector-odbc: remove expired port
>> ---
>> MOVED                                              |  1 +
>> databases/Makefile                                 |  1 -
>> databases/mysql-connector-odbc/Makefile            | 38 =
----------------------
>> databases/mysql-connector-odbc/distinfo            |  3 --
>> .../files/patch-CMakeLists.txt                     | 30 =
-----------------
>> .../mysql-connector-odbc/files/patch-driver_dll.cc | 11 -------
>> .../files/patch-driver_handle.cc                   | 11 -------
>> databases/mysql-connector-odbc/pkg-descr           |  1 -
>> 8 files changed, 1 insertion(+), 95 deletions(-)
>>=20
>> diff --git a/MOVED b/MOVED
>> index bfe2d1dcb026..6823b3c2e314 100644
>> --- a/MOVED
>> +++ b/MOVED
>> @@ -17765,3 +17765,4 @@ =
x11/plasma5-kwayland-server|x11-wm/plasma5-kwin|2023-02-07|Reintegrated =
into x11
>> finance/py-TA-Lib|finance/py-ta-lib|2023-02-12|Remove duplicate port
>> x11-toolkits/gnocl||2023-02-13|Fails to build, newer snapshot depends =
on a removed port
>> games/opendungeons||2023-02-14|Has expired: Broken for more than 6 =
months
>> =
+databases/mysql-connector-odbc|databases/mysql-connector-odbc-80|2023-02-=
18|Has expired: Requires EOLd mysql version
>> diff --git a/databases/Makefile b/databases/Makefile
>> index 3a6cbb867cc9..598e34d376ae 100644
>> --- a/databases/Makefile
>> +++ b/databases/Makefile
>> @@ -204,7 +204,6 @@
>>    SUBDIR +=3D mysql-connector-c++
>>    SUBDIR +=3D mysql-connector-java
>>    SUBDIR +=3D mysql-connector-java51
>> -    SUBDIR +=3D mysql-connector-odbc
>>    SUBDIR +=3D mysql-connector-odbc-80
>>    SUBDIR +=3D mysql-q4m
>>    SUBDIR +=3D mysql-udf
>> diff --git a/databases/mysql-connector-odbc/Makefile =
b/databases/mysql-connector-odbc/Makefile
>> deleted file mode 100644
>> index b61392aee08b..000000000000
>> --- a/databases/mysql-connector-odbc/Makefile
>> +++ /dev/null
>> @@ -1,38 +0,0 @@
>> -PORTNAME=3D mysql-connector-odbc
>> -PORTVERSION=3D 5.3.14
>> -CATEGORIES=3D databases
>> -MASTER_SITES=3D MYSQL/Connector-ODBC/5.3
>> -PKGNAMESUFFIX=3D -${DRIVER_MANAGER}-mysql${MYSQL_VER}
>> -DISTNAME=3D ${PORTNAME}-${PORTVERSION}-src
>> -
>> -MAINTAINER=3D bofh@FreeBSD.org
>> -COMMENT=3D ODBC driver for MySQL${MYSQL_VER} / ${DRIVER_MANAGER}
>> -WWW=3D https://www.mysql.com/
>> -
>> -LICENSE=3D GPLv2
>> -LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt
>> -
>> -DEPRECATED=3D Requires EOLd mysql version
>> -EXPIRATION_DATE=3D 2023-12-31
>> -
>> -LIB_DEPENDS=3D libodbc.so:databases/unixODBC
>> -
>> -USES=3D cmake compiler:c++11-lang localbase:ldflags mysql ssl
>> -IGNORE_WITH_MYSQL=3D 101m 102m 103m 57p 57w 80
>> -USE_LDCONFIG=3D yes
>> -
>> -CMAKE_ARGS=3D -DDISABLE_GUI=3D1 \
>> - -DWITH_UNIXODBC=3D1
>> -
>> -MAKE_JOBS_UNSAFE=3D yes
>> -
>> -DRIVER_MANAGER=3D unixodbc
>> -
>> -PLIST_FILES=3D bin/myodbc-installer \
>> - lib/libmyodbc5a.so \
>> - lib/libmyodbc5w.so
>> -PORTDOCS=3D *
>> -
>> -OPTIONS_DEFINE=3D DOCS
>> -
>> -.include <bsd.port.mk>
>> diff --git a/databases/mysql-connector-odbc/distinfo =
b/databases/mysql-connector-odbc/distinfo
>> deleted file mode 100644
>> index 702e816bc4ff..000000000000
>> --- a/databases/mysql-connector-odbc/distinfo
>> +++ /dev/null
>> @@ -1,3 +0,0 @@
>> -TIMESTAMP =3D 1675364196
>> -SHA256 (mysql-connector-odbc-5.3.14-src.tar.gz) =3D =
302d068ef0d8e1e9ada6e42e48c149151d4b722f9317efb106f801e483e74a7f
>> -SIZE (mysql-connector-odbc-5.3.14-src.tar.gz) =3D 3010166
>> diff --git =
a/databases/mysql-connector-odbc/files/patch-CMakeLists.txt =
b/databases/mysql-connector-odbc/files/patch-CMakeLists.txt
>> deleted file mode 100644
>> index f184b2a0e6f4..000000000000
>> --- a/databases/mysql-connector-odbc/files/patch-CMakeLists.txt
>> +++ /dev/null
>> @@ -1,30 +0,0 @@
>> ---- CMakeLists.txt.orig 2019-04-15 16:56:34 UTC
>> -+++ CMakeLists.txt
>> -@@ -431,7 +431,6 @@ ENDIF(NOT DISABLE_GUI)
>> -
>> - ADD_SUBDIRECTORY(dltest)
>> - ADD_SUBDIRECTORY(installer)
>> --ADD_SUBDIRECTORY(test)
>> -
>> - # For dynamic linking use the built-in sys and strings
>> - IF(NOT MYSQLCLIENT_STATIC_LINKING)
>> -@@ -501,8 +500,8 @@ cmake/sql.*\\\\.c$
>> - #------------ Installation ---------------------------
>> -
>> -
>> --INSTALL(FILES LICENSE.txt   DESTINATION .)
>> --INSTALL(FILES README.txt    DESTINATION .)
>> -+INSTALL(FILES LICENSE.txt   DESTINATION =
./share/doc/mysql-connector-odbc/)
>> -+INSTALL(FILES README.txt    DESTINATION =
./share/doc/mysql-connector-odbc/)
>> -
>> - IF(WIN32)
>> -
>> -@@ -542,7 +541,7 @@ IF(WIN32)
>> -
>> - ELSE(WIN32)
>> -
>> --  INSTALL(FILES ChangeLog    DESTINATION .)
>> -+  INSTALL(FILES ChangeLog    DESTINATION =
./share/doc/mysql-connector-odbc/)
>> -
>> - ENDIF(WIN32)
>> -
>> diff --git a/databases/mysql-connector-odbc/files/patch-driver_dll.cc =
b/databases/mysql-connector-odbc/files/patch-driver_dll.cc
>> deleted file mode 100644
>> index b69ce6b9e812..000000000000
>> --- a/databases/mysql-connector-odbc/files/patch-driver_dll.cc
>> +++ /dev/null
>> @@ -1,11 +0,0 @@
>> ---- driver/dll.cc.orig 2019-04-15 16:56:34 UTC
>> -+++ driver/dll.cc
>> -@@ -125,7 +125,7 @@ void myodbc_end()
>> -        This eliminates the delay when mysys_end() is called and =
other threads
>> -        have been initialized but not ended.
>> -     */
>> --    my_thread_end_wait_time=3D 0;
>> -+    static uint my_thread_end_wait_time=3D 0;
>> - #endif
>> -
>> - /*
>> diff --git =
a/databases/mysql-connector-odbc/files/patch-driver_handle.cc =
b/databases/mysql-connector-odbc/files/patch-driver_handle.cc
>> deleted file mode 100644
>> index 3a12e522fa4e..000000000000
>> --- a/databases/mysql-connector-odbc/files/patch-driver_handle.cc
>> +++ /dev/null
>> @@ -1,11 +0,0 @@
>> ---- driver/handle.cc.orig 2019-04-15 16:56:34 UTC
>> -+++ driver/handle.cc
>> -@@ -646,7 +646,7 @@ SQLRETURN SQL_API =
my_SQLFreeStmtExtended(SQLHSTMT hstm
>> - #if MYSQL_VERSION_ID >=3D 50722 && MYSQL_VERSION_ID < 80000
>> -       if (stmt->result !=3D NULL
>> - #else
>> --      if((stmt->result !=3D NULL) && (stmt->result->field_alloc !=3D =
NULL)
>> -+      if((stmt->result !=3D NULL) && (&stmt->result->field_alloc !=3D=
 NULL)
>> - #if (!MYSQLCLIENT_STATIC_LINKING || !MYSQL8)
>> -          && (stmt->result->field_alloc.pre_alloc !=3D NULL )
>> - #endif
>> diff --git a/databases/mysql-connector-odbc/pkg-descr =
b/databases/mysql-connector-odbc/pkg-descr
>> deleted file mode 100644
>> index 0441dd6a5d7f..000000000000
>> --- a/databases/mysql-connector-odbc/pkg-descr
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -MySQL Connector ODBC is an ODBC driver for interfacing to MySQL =
databases.
>>=20
>>=20


--Apple-Mail=_210622DF-0315-4905-B7F3-4AB23EAA2E67
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmPxSrNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE
Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA
vJG7OQ/7BPnLYmppy7LAz576rHic/psRupBUzLbQ+vHQHW3QbSUaAw3WQl1xUdLe
J/x2txre8Qkc50G9fIOS4JCuxp4k7ubnHhz2z8ivStU5nhzQ4jHjrRc2Nzm/tm6P
qae73z44piX4e4DEvbQDloFbDVra0DTbdab3xxo3OWNMeL/xq8x4Oyn6krM/8CAJ
sfxRm2QZjOrgujzMKjwyHr0Sjs7EEmg3JGX/Ny5ZC2/sE/OmWjus0jA2BfIY8M6Y
3hAWF1VVzTc3HlPBMvrSAOdstVL+kXdtTtTg9inZTYHjDQjOiPKHRBihzyF97xC6
onno1kK+/5DtNNsCAVwIs38mFUoZrdygoee8eTlj4UbCreD2QfhhZv4SYsYJjIgI
4nQcaVjtwwE/4R4XRCr93kh+6YzAFLPxdCrAvqcHWCBBrM9tvYFdUjBPa/wRCgcd
HeGIcmOrqo/iQimw9p0kKBOaf0n0Ed7ADdjEtN0FEAOO2UJFQCk9QFgpVQr4/XFX
J/MG5zJMkRSpq21ZAmIx33+7VOzpUwjmfn3W5CJhZnBuJGEa+xtQHpzjHEK0GsRs
pjOXfXKYypAj/ZWTePP71txOSyLJsaggRGq4iafD+veO0capqAi1PlIPvttRGIOo
Kb8JdvlJ2gLNeQ0L4aTxEnK5RL9ZWvqs9ErwtFjK7E2bkO/4qfU=
=pqvl
-----END PGP SIGNATURE-----

--Apple-Mail=_210622DF-0315-4905-B7F3-4AB23EAA2E67--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F8E09111-EEF6-402C-8D22-DC1A6AE9D78F>