From owner-freebsd-bugs@FreeBSD.ORG  Thu Jun  5 03:30:10 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3AF3337B401
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  5 Jun 2003 03:30:10 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D8BAF43FAF
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  5 Jun 2003 03:30:09 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h55AU9Up018019
	for <freebsd-bugs@freefall.freebsd.org>;
	Thu, 5 Jun 2003 03:30:09 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h55AU9or018018;
	Thu, 5 Jun 2003 03:30:09 -0700 (PDT)
Date: Thu, 5 Jun 2003 03:30:09 -0700 (PDT)
Message-Id: <200306051030.h55AU9or018018@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dmitry Sivachenko <mitya@demos.su>
Subject: Re: kern/52960: kbdcontrol macros don't work when len%
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Dmitry Sivachenko <mitya@demos.su>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jun 2003 10:30:10 -0000

The following reply was made to PR kern/52960; it has been noted by GNATS.

From: Dmitry Sivachenko <mitya@demos.su>
To: freebsd-gnats-submit@FreeBSD.org
Cc: mat@hak.cnd.mcgill.ca
Subject: Re: kern/52960: kbdcontrol macros don't work when len%
Date: Thu, 5 Jun 2003 14:24:50 +0400

 The following patch fixes the problem.  When you supply exactly
 MAXFK(=16) chararacters as a macro, you should use strncpy which does not
 append trailing '\0'.
 
 
 --- kbdcontrol.c.orig	Thu Jun  5 14:19:13 2003
 +++ kbdcontrol.c	Thu Jun  5 14:17:52 2003
 @@ -848,7 +848,7 @@
  			fkey.flen, MAXFK);
  		return;
  	}
 -	strcpy(fkey.keydef, string);
 +	strncpy(fkey.keydef, string, MAXFK);
  	fkey.keynum -= 1;
  	if (ioctl(0, SETFKEY, &fkey) < 0)
  		warn("setting function key");