From owner-svn-src-all@FreeBSD.ORG  Mon Feb  9 16:53:37 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B75031065675;
	Mon,  9 Feb 2009 16:53:37 +0000 (UTC)
	(envelope-from fjoe@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id A679A8FC17;
	Mon,  9 Feb 2009 16:53:37 +0000 (UTC)
	(envelope-from fjoe@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n19GrbXs065500;
	Mon, 9 Feb 2009 16:53:37 GMT (envelope-from fjoe@svn.freebsd.org)
Received: (from fjoe@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n19GrbIB065499;
	Mon, 9 Feb 2009 16:53:37 GMT (envelope-from fjoe@svn.freebsd.org)
Message-Id: <200902091653.n19GrbIB065499@svn.freebsd.org>
From: Max Khon <fjoe@FreeBSD.org>
Date: Mon, 9 Feb 2009 16:53:37 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r188392 - head/sys/pci
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Feb 2009 16:53:38 -0000

Author: fjoe
Date: Mon Feb  9 16:53:37 2009
New Revision: 188392
URL: http://svn.freebsd.org/changeset/base/188392

Log:
  Destroy TX tag outside of loop scope.
  
  Found with:	Coverity Prevent(tm)
  CID:		3886

Modified:
  head/sys/pci/if_rl.c

Modified: head/sys/pci/if_rl.c
==============================================================================
--- head/sys/pci/if_rl.c	Mon Feb  9 15:55:21 2009	(r188391)
+++ head/sys/pci/if_rl.c	Mon Feb  9 16:53:37 2009	(r188392)
@@ -1151,9 +1151,9 @@ rl_dma_free(struct rl_softc *sc)
 				    sc->rl_cdata.rl_tx_dmamap[i]);
 				sc->rl_cdata.rl_tx_dmamap[i] = NULL;
 			}
+		}
 		bus_dma_tag_destroy(sc->rl_cdata.rl_tx_tag);
 		sc->rl_cdata.rl_tx_tag = NULL;
-		}
 	}
 
 	if (sc->rl_parent_tag != NULL) {