Date: Sat, 15 Jul 2023 09:01:07 -0500 From: Matthew Grooms <mgrooms@shrew.net> To: Rob Wing <rob.fx907@gmail.com> Cc: "virtualization@freebsd.org" <virtualization@freebsd.org> Subject: Re: BHYVE SNAPSHOT image format proposal Message-ID: <3a037482-2e6c-667f-1979-d5b612e506ec@shrew.net> In-Reply-To: <CAF3%2Bn_czuJ=B2mok2wh7OPvkzMz7%2B9KRG8_NuCyEL9SMFLt6tw@mail.gmail.com> References: <67FDC8A8-86A6-4AE4-85F0-FF7BEF9F2F06@gmail.com> <6b98da58a5bd8e83bc466efa20b5a900298210aa.camel@FreeBSD.org> <8387AC83-6667-48E5-A3FA-11475EA96A5F@gmail.com> <d92db9bfbea181d6eb9d57b579d67e8e118ef4de.camel@FreeBSD.org> <986A83D8-E0E0-4030-9369-A5B3500E27C6@gmail.com> <79fabe94-b800-c713-48ea-518da1f74e4d@shrew.net> <CAF3%2Bn_cc5ZpGsKCff%2Bu-rSjnJn%2BN1jdu9KW0Y5b6n_TieMsfng@mail.gmail.com> <3973013d-c183-360f-d7ca-ca822859c23d@shrew.net> <CAF3%2Bn_czuJ=B2mok2wh7OPvkzMz7%2B9KRG8_NuCyEL9SMFLt6tw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/14/23 19:07, Rob Wing wrote: > The review you referenced requires multiple files for a snapshot, which > I think is a non-starter. > We'll overlook the fact that it does attempt to consolidate files ( 2 vs 3 ) and that there's no feedback requesting further consolidation after being open for two years, but noted. > I was trying to ensure that the limitations described in the original > snapshot commit message are addressed appropriately - but maybe I've > mis-interpreted the message or that I don't fully understand the problem. > Since we're trying to ensure that limitations in the original commit message are addressed, let's read that ... https://reviews.freebsd.org/rS360648 "While the current implementation is useful for several uses cases, it has a few limitations. The file format for saving the guest state is tied to the ABI of internal bhyve structures and is not self-describing (in that it does not communicate the set of device models present in the system). In addition, the state saved for some device models closely matches the internal data structures which might prove a challenge for compatibility of snapshot files across a range of bhyve versions." The UPB patch addresses the above. Vitaliy's patch does nothing to address any of it. If one is going to be proposed as an alternative to the other, it better solve the same problems as then some. > I don't want give unhelpful or contradictory suggestions to what you've > received in the past. > The best I can do at this point is defer to those who you have made > these agreements with. > The silence is real. -Matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a037482-2e6c-667f-1979-d5b612e506ec>