From owner-cvs-src@FreeBSD.ORG Wed Oct 29 21:14:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF5E316A4CF for ; Wed, 29 Oct 2003 21:14:38 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 0102743FE9 for ; Wed, 29 Oct 2003 21:14:37 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 86816 invoked by uid 1000); 30 Oct 2003 05:14:39 -0000 Date: Wed, 29 Oct 2003 21:14:39 -0800 (PST) From: Nate Lawson To: "M. Warner Losh" In-Reply-To: <20031029.220629.102576808.imp@bsdimp.com> Message-ID: <20031029210945.A86732@root.org> References: <20031028235425.N82902@root.org> <20031029.013316.32322618.imp@bsdimp.com> <20031029.220629.102576808.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/i386/acpica Makefile acpi_wakecode.S src/sys/i386/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Oct 2003 05:14:39 -0000 On Wed, 29 Oct 2003, M. Warner Losh wrote: > In message: <20031029100945.F84859@root.org> > Nate Lawson writes: > : On Wed, 29 Oct 2003, M. Warner Losh wrote: > : > In message: <20031028235425.N82902@root.org> > : > Nate Lawson writes: > : > : Is this needed? options alone should be sufficient and acpi_wakeup.S > : > : should include opt_acpi.h. > : > > : > Not for kernel modules... > : > : Muagh. > : > : Ok, I'm starting a pot for whoever will finally implement the combined > : kernel modules and kernel config build tree. $10 US via PayPal. Care to > : contribute? > > Not for this. Options for kernel compilation should only really be > used for ABI issues. better to make this a tunable/sysctl. Non-sequitur. The issue still stands that module builds don't pull in the kernel config file, forcing duplication in make.conf. When building a kernel+modules, options in opt_*.h should be included in the module build. This is even under the 5.2-TODO as "Revised kld build infrastructure". I was just indicating that the number of times this has bothered me was worth $10 to the author of the fix. Maybe it's bothered enough others that it's worth a few hundred $ aggregate. :) I'll up it to $20. -Nate