From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Aug 27 13:30:19 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 289E91065670 for ; Mon, 27 Aug 2012 13:30:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E0DBD8FC22 for ; Mon, 27 Aug 2012 13:30:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7RDUIPa012250 for ; Mon, 27 Aug 2012 13:30:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7RDUIjg012247; Mon, 27 Aug 2012 13:30:18 GMT (envelope-from gnats) Resent-Date: Mon, 27 Aug 2012 13:30:18 GMT Resent-Message-Id: <201208271330.q7RDUIjg012247@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Lung-Pin Chang Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6227C1065670; Mon, 27 Aug 2012 13:25:32 +0000 (UTC) (envelope-from iamben@iamben.csie.net) Received: from Archon.iamben.csie.net (iamben.cs.nctu.edu.tw [140.113.17.199]) by mx1.freebsd.org (Postfix) with ESMTP id 2CE158FC18; Mon, 27 Aug 2012 13:25:29 +0000 (UTC) Received: by Archon.iamben.csie.net (Postfix, from userid 1001) id 4C8C29B41F; Mon, 27 Aug 2012 21:25:22 +0800 (CST) Message-Id: <20120827132522.4C8C29B41F@Archon.iamben.csie.net> Date: Mon, 27 Aug 2012 21:25:22 +0800 (CST) From: Lung-Pin Chang To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: sbz@FreeBSD.org Subject: ports/171117: [PATCH] security/knock: Duplicated flags X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2012 13:30:19 -0000 >Number: 171117 >Category: ports >Synopsis: [PATCH] security/knock: Duplicated flags >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Aug 27 13:30:16 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Lung-Pin Chang >Release: FreeBSD 9.0-RELEASE amd64 >Organization: >Environment: System: FreeBSD Archon.iamben.csie.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC >Description: /etc/rc.subr already loads ${name}_flags as part of command line arguments. Putting $knockd_flags into $command_args causes the flags to be duplicated twice. e.g. root 75681 0.0 0.0 12324 1064 ?? Rs 9:18PM 0:00.88 /usr/local/bin/knockd -d -d Port maintainer (sbz@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: >Fix: --- knock-0.5_1,1.patch begins here --- diff -ruN --exclude=CVS /usr/ports/security/knock/Makefile /home/iamben/tmp/ports/security/knock/Makefile --- /usr/ports/security/knock/Makefile 2012-08-06 07:19:36.000000000 +0800 +++ /home/iamben/tmp/ports/security/knock/Makefile 2012-08-27 21:17:31.089871996 +0800 @@ -7,6 +7,7 @@ PORTNAME= knock PORTVERSION= 0.5 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= security MASTER_SITES= http://www.zeroflux.org/proj/knock/files/ \ diff -ruN --exclude=CVS /usr/ports/security/knock/files/knockd.in /home/iamben/tmp/ports/security/knock/files/knockd.in --- /usr/ports/security/knock/files/knockd.in 2012-08-06 07:19:36.000000000 +0800 +++ /home/iamben/tmp/ports/security/knock/files/knockd.in 2012-08-27 21:17:16.335874460 +0800 @@ -27,7 +27,6 @@ : ${knockd_flags="-d"} command="%%PREFIX%%/bin/knockd" -command_args=${knockd_flags} pidfile="/var/run/knockd.pid" required_files=${knockd_conf} --- knock-0.5_1,1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: