From nobody Mon Jul 7 13:32:02 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbQBs0Mprz61krT for ; Mon, 07 Jul 2025 13:32:05 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from mx.catwhisker.org (mx.catwhisker.org [107.204.234.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbQBr1GbLz49ry for ; Mon, 07 Jul 2025 13:32:04 +0000 (UTC) (envelope-from david@catwhisker.org) Authentication-Results: mx1.freebsd.org; none Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.18.1/8.18.1) with ESMTP id 567DW2US023715; Mon, 7 Jul 2025 13:32:02 GMT (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.18.1/8.18.1/Submit) id 567DW2NA023714; Mon, 7 Jul 2025 06:32:02 -0700 (PDT) (envelope-from david) Date: Mon, 7 Jul 2025 06:32:02 -0700 From: David Wolfskill To: Konstantin Belousov Cc: Oleg Nauman , FreeBSD Current Subject: Re: tail -f is broken in recent CURRENT ( afd5bc630930 Sunday Jul 6 ) Message-ID: Mail-Followup-To: David Wolfskill , Konstantin Belousov , Oleg Nauman , FreeBSD Current References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IJElJ2NENWxrnFvJ" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4bbQBr1GbLz49ry X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:7018, ipnet:107.192.0.0/12, country:US] --IJElJ2NENWxrnFvJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 07, 2025 at 03:51:00PM +0300, Konstantin Belousov wrote: > ... > Try this >=20 > diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h > index 3ed469bdce6d..2c6947103c94 100644 > --- a/sys/sys/vnode.h > +++ b/sys/sys/vnode.h > @@ -1032,7 +1032,7 @@ void vop_rename_fail(struct vop_rename_args *ap); > #define VOP_WRITE_POST(ap, ret) \ > noffset =3D (ap)->a_uio->uio_offset; \ > if (noffset > ooffset) { \ > - if (VN_KNLIST_EMPTY((ap)->a_vp)) { \ > + if (!VN_KNLIST_EMPTY((ap)->a_vp)) { \ > VFS_KNOTE_LOCKED((ap)->a_vp, NOTE_WRITE | \ > (noffset > osize ? NOTE_EXTEND : 0)); \ > } \ >=20 OK; did that, to sources as of main-n278527-07948e050808, then rebuilt the kernel. Seems to have done the job: this is a dedicated "build machine," so I had a small challenge finding a suitable reproduction, but I saw that /var/log/cron was getting updated every 5 minutes from atrun, so after having booted: freebeast(15.0-C)[5] uname -aUK FreeBSD freebeast.catwhisker.org 15.0-CURRENT FreeBSD 15.0-CURRENT #264 mai= n-n278527-07948e050808-dirty: Mon Jul 7 13:14:31 UTC 2025 root@freebea= st.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1500= 051 1500051 I then: freebeast(15.0-C)[5] sudo tail -F /var/log/cron and after waiting a few minutes, I was gratified to see: Jul 7 06:30:00 freebeast /usr/sbin/cron[2415]: (root) CMD (/usr/libexec/at= run) show up. Seems to be working. :-) Thanks, Konstantin -- and Oleg! :-) Peace, david --=20 David H. Wolfskill david@catwhisker.org "The whole idea of reciprocal tariffs is if someone's punching me in the face, I'm going to punch myself in the face." -- Warwick McKibbin See https://www.catwhisker.org/~david/publickey.gpg for my public key. --IJElJ2NENWxrnFvJ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQSTLzOSbomIK53fjFliipiWhXYx5QUCaGvMUl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0OTMy RjMzOTI2RTg5ODgyQjlEREY4QzU5NjI4QTk4OTY4NTc2MzFFNQAKCRBiipiWhXYx 5Y/PAP9ysP8qDduS63IIBzHJkMH6s73hYri1q0loV1G1a+ahSAD+LZAX6vAkjc3C HPE9eVRm6raW28LKSs0gcI0kxTI9GQ4= =MEaa -----END PGP SIGNATURE----- --IJElJ2NENWxrnFvJ--