From owner-p4-projects@FreeBSD.ORG  Mon Oct  2 21:04:44 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5F05816A47B; Mon,  2 Oct 2006 21:04:44 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 22AC016A403
	for <perforce@freebsd.org>; Mon,  2 Oct 2006 21:04:44 +0000 (UTC)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CBB9043D4C
	for <perforce@freebsd.org>; Mon,  2 Oct 2006 21:04:43 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k92L4hHW098330
	for <perforce@freebsd.org>; Mon, 2 Oct 2006 21:04:43 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k92L4h5Y098327
	for perforce@freebsd.org; Mon, 2 Oct 2006 21:04:43 GMT
	(envelope-from imp@freebsd.org)
Date: Mon, 2 Oct 2006 21:04:43 GMT
Message-Id: <200610022104.k92L4h5Y098327@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 107122 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Oct 2006 21:04:44 -0000

http://perforce.freebsd.org/chv.cgi?CH=107122

Change 107122 by imp@imp_lighthouse on 2006/10/02 21:03:43

	Fix botched done call.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/at91_mci.c#15 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/at91_mci.c#15 (text+ko) ====

@@ -348,7 +348,7 @@
 		WR4(sc, MCI_IER, MCI_SR_ERROR | MCI_SR_CMDRDY);
 		return;
 	}
-//	panic();
+	panic("WRITE THE DATA HANDLER");
 }
 
 static void
@@ -371,7 +371,7 @@
 	/* We must be done -- bad idea to do this while locked? */
 	sc->req = NULL;
 	sc->curcmd = NULL;
-	req->done(req->done_data);
+	req->done(req);
 }
 
 static int