From nobody Wed Nov 1 00:37:46 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SKp5258VNz4y98Z for ; Wed, 1 Nov 2023 00:37:58 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SKp5211pvz3Knk; Wed, 1 Nov 2023 00:37:58 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1cc3bc5df96so24899245ad.2; Tue, 31 Oct 2023 17:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698799077; x=1699403877; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yQvUBb8eP5BIvwAjq6wCleLY88/yT2kiqS90RRtyZNU=; b=DUEfZz0oQATpxoAk6TGQduvaJ0LJJfc87+OopxxZgVV1XMSdbqW9nUYllmhDv3kWGT +bJngSt3kz+CEakcOC3s6U1yGXZyrlABU6w9JUrUMuSbhZhccwtqFSqUMHHrfxBcvF0u Yx0tTY+cey7shdK+bMG7LPA8X9Vy8qlPTekOQ1h497+c3Pt6rsWIW+lspXIKvHxZCPq0 NinsMnyl2yEbJ/3ql89uro6qg43wae6YEbjIzkVPJobm8IW2ZY1tdjPpzdVMXk46wbdy rkhihiqBC/3GRFBfjc71KW111Ggzc71j/tUSlDYTsh+lPaIirxuV5LYnS1/xiXiuKVxp mKog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698799077; x=1699403877; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yQvUBb8eP5BIvwAjq6wCleLY88/yT2kiqS90RRtyZNU=; b=va2oPwge3bC4rJMgUXx21f/aKCNq11+hiSe3L68tKfb++M0xaXwXAinFZsnyuUneLJ cWFCoVLn60GVBauNuioeMrSwBmvnDaesIGJHnwhrhwCLcoYsxnAgwm2mPxceVXGUBYJ7 LBxwFtaTk82KK64INyhhUP8IfPPFne7uTL4lcXYA7mllFpqDjuseXObazP4LIS0l8vjl zQ6X/747VILKCuROcfW0J9MECJDtStQSFYUuPA7+ROU9lsFtYufRdiGD7f8i4uc7D4i6 Hrbg+HQl14UD39G2bUEtRKWYx32fcXhQVZbC3HR0GaNjJjcU2ALwqrBJe3/+E91G0/+T 7Kkg== X-Gm-Message-State: AOJu0Ywp/sLPWIhmc5IG5uiy3hhi7VZxvORvc8G8qjYFEHV5Jj0Q1Hld Aat4oMFOF/L7nQDQA8aOzh1yeiPHiy9GYIAbppRNhooe2A== X-Google-Smtp-Source: AGHT+IGprBf9kbnPiB4i8NpTkNYbfJDzTCgec6SHezl8Cw/QlQOaxDocrcpe5EmQuVwfxPdlqRQiL9n7xMmQv9eC7eQ= X-Received: by 2002:a17:90b:4a05:b0:280:99f0:4234 with SMTP id kk5-20020a17090b4a0500b0028099f04234mr2854767pjb.7.1698799076804; Tue, 31 Oct 2023 17:37:56 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <53AC8651-141E-4950-84D9-FD94E8B353FD@FreeBSD.org> <77952261-2fe0-428e-b72c-d805f0273a76@FreeBSD.org> In-Reply-To: <77952261-2fe0-428e-b72c-d805f0273a76@FreeBSD.org> From: Rick Macklem Date: Tue, 31 Oct 2023 17:37:46 -0700 Message-ID: Subject: Re: KTLS thread on 14.0-RC3 To: John Baldwin Cc: Zhenlei Huang , Gordon Bergling , FreeBSD Current , gallatin@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[] X-Rspamd-Queue-Id: 4SKp5211pvz3Knk On Tue, Oct 31, 2023 at 10:06=E2=80=AFAM John Baldwin wro= te: > > On 10/30/23 3:41 AM, Zhenlei Huang wrote: > > > > > >> On Oct 30, 2023, at 12:09 PM, Zhenlei Huang wrote: > >> > >> > >> > >>> On Oct 29, 2023, at 5:43 PM, Gordon Bergling wrote: > >>> > >>> Hi, > >>> > >>> I am currently building a new system, which should be based on 14.0-R= ELEASE. > >>> Therefor I am tracking releng/14.0 since its creation and updating it= currently > >>> via the usualy buildworld steps. > >>> > >>> What I have noticed recently is, that the [KTLS] is missing. I have a= stable/13 > >>> system which shows the [KTLS] thread and a very recent -CURRENT that = also shows > >>> the [KTLS] thread. > >>> > >>> The stable/13 and releng/14.0 systems both use the GENERIC kernel, wi= thout any > >>> custom modifications. > >>> > >>> Loaded KLDs are also the same. > >>> > >>> Did I miss something, or is there something in releng/14.0 missing, w= hich > >>> is currenlty enabled in stable/13? > >> > >> KTLS shall still work as intended, the creation of it threads is defer= red. > >> > >> See a72ee355646c (ktls: Defer creation of threads and zones until firs= t use) > >>> Run ktls_init() when the first KTLS session is created rather than > >>> unconditionally during boot. This avoids creating unused threads and > >>> allocating unused resources on systems which do not use KTLS. > >> > >> ``` > >> -SYSINIT(ktls, SI_SUB_SMP + 1, SI_ORDER_ANY, ktls_init, NULL); > >> ``` > > > > Seems 14.0 only create one KTLS thread. > > > > IIRC 13.2 create one thread per core. > > That part should not be different. There should always be one thread per= core. Just fyi, I see one thread/core. Did you happen to do something like "ps ax" instead of "ps axHl"? rick ps: I also see a reclaim_0 thread. > > -- > John Baldwin > >