Date: 14 Jul 2002 02:07:57 +0200 From: Yann Droneaud <ydroneaud@meuh.eu.org> To: Ville =?iso-8859-1?q?Skytt=E4?= <scop@FreeBSD.org> Cc: Yann Droneaud <ydroneaud@meuh.eu.org>, freebsd-cvsweb@FreeBSD.org Subject: Re: [PATCH] download + javascript Message-ID: <86wurz189u.fsf@random.chezwam.org> In-Reply-To: <1026600150.1936.19.camel@bobcat.ods.org> References: <86bs9c6a9y.fsf@random.chezwam.org> <1026600150.1936.19.camel@bobcat.ods.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ville Skyttä <scop@FreeBSD.org> writes:
> On Fri, 2002-07-12 at 22:01, Yann Droneaud wrote:
>
> > I got some problems when clicking on "download" links,
> > it reports me error. So i try to fix it. Here is the result.
> >
> > It set the javascript link to be like the html link.
> > It seems to work for me.
>
> Thanks for the patch, Yann!
>
> While I agree that the HTML and Javascript links should be the same, I'd
> be interested to hear exactly what kind of errors have you ran into
> without this fix?
>
> A Javascript error reported by your browser, an error message sent by
> the server and/or an error in the server log?
>
> It would be nice if you could send some HTML source of a page that
> causes these errors. I'd like to be sure that this is the correct fix,
> and not just a workaround for the problem.
>
> Cheers,
> --
> \/ille Skyttä
>
>
For the others cvsroot than the default, in the 'CVS log' page, when i hit the url download,
I simply get 440 error message, because the file i wanted to see doesn't exist.
Here is the example of page with bad javascript code:
<h1 align="center">CVS log for vhffs-dyndns/vhffs-dyndns/ChangeLog</h1>
<p>
<a href="/cvs/vhffs-dyndns/vhffs-dyndns/?cvsroot=vhffs-deb#ChangeLog"><img src="/icons/back.gif" alt="[BACK]" border="0" width="20" height="22"></a> <b>Up to <a href="/cvs/?cvsroot=vhffs-deb#dirlist">[vhffs-deb]</a> / <a href="/cvs/vhffs-dyndns/?cvsroot=vhffs-deb#dirlist">vhffs-dyndns</a> / <a href="/cvs/vhffs-dyndns/vhffs-dyndns/?cvsroot=vhffs-deb#dirlist">vhffs-dyndns</a></b>
</p>
<p>
<a href="#diff">Request diff between arbitrary revisions</a>
</p>
<hr noshade>
<p>
Default branch: creis, MAIN<br>
</p>
<hr size="1" noshade>
<p>
<a name="rev1.1.1.1.2.7"></a><a name="meuh"></a>
Revision <a href="ChangeLog?rev=1.1.1.1.2.7&content-type=text/x-cvsweb-markup&cvsroot=vhffs-deb"><b>1.1.1.1.2.7</b></a> /
(<a href="/cvs/~checkout~/vhffs-dyndns/vhffs-dyndns/ChangeLog?rev=1.1.1.1.2.7&content-type=text/plain&cvsroot=vhffs-deb" target="cvs_checkout"
onclick="window.open('/cvs/~checkout~/vhffs-dyndns/vhffs-dyndns/ChangeLog?rev=1.1.1.1.2.7&content-type=text/plain','cvs_checkout','resizeable,scrollbars');
return false">
<b>download</b></a>) -
<a href="/cvs/vhffs-dyndns/vhffs-dyndns/ChangeLog?r1=1.1.1.1.2.7&cvsroot=vhffs-deb">[select for diffs]</a>, <i>Tue Feb 19 20:51:32 2002 UTC</i> (4 months, 3 weeks ago) by <i>meuh</i>
<br>Branch: <b><a href="./ChangeLog?cvsroot=vhffs-deb&only_with_tag=meuh">meuh</a>
</b>
Hop this is useful for you.
--
Yann Droneaud <ydroneaud@meuh.eu.org> +33 6 88 40 82 43
<ydroneaud@tuxfamily.org> <yann.droneaud@iupmime.univ-lemans.fr>
1024D/BEA43321 5D91 B5B0 5137 B8FE 6882 FE19 CAA0 6F05 BEA4 3321
http://www.meuh.eu.org/ http://www-iupmime.univ-lemans.fr/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-cvsweb" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86wurz189u.fsf>