From owner-freebsd-stable@FreeBSD.ORG Sat Jan 8 18:18:06 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C65510656AA; Sat, 8 Jan 2011 18:18:06 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe02.c2i.net [212.247.154.34]) by mx1.freebsd.org (Postfix) with ESMTP id 87EE38FC1B; Sat, 8 Jan 2011 18:18:05 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=V/BmsFzUvwB31XiPFgiZP9ZGx4++v9AH3cfAZ6JEaj8= c=1 sm=1 a=d7IFvdU83yMA:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=Rm3tFodZxdn1bf3s9rAA:9 a=eWDDUQYRfZCoE4t-wDQA:7 a=hAnKZw0fKNzF20Is4fnkFTFWlbUA:4 a=wPNLvfGTeEIA:10 a=Gi6b3XPG2v-FT_WttCcA:9 a=E_ILL27bHwPWKX1PjvkA:7 a=ejEqwGQXeCW6pxHW1zkQhxGt_QIA:4 a=i9M/sDlu2rpZ9XS819oYzg==:117 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 71613595; Sat, 08 Jan 2011 19:18:03 +0100 From: Hans Petter Selasky To: freebsd-stable@freebsd.org, Nick Hibma Date: Sat, 8 Jan 2011 19:18:09 +0100 User-Agent: KMail/1.13.5 (FreeBSD/8.1-STABLE; KDE/4.4.5; amd64; ; ) References: <201101081841.10690.hselasky@c2i.net> In-Reply-To: <201101081841.10690.hselasky@c2i.net> X-Face: +~\`s("[*|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA: hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L' MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_hpKKNWNCVpMh/2S" Message-Id: <201101081918.09664.hselasky@c2i.net> Cc: freebsd-multimedia@freebsd.org, kwm@freebsd.org, Kris Moore Subject: Re: Webcamd testers wanted on FreeBSD 8.2 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2011 18:18:06 -0000 --Boundary-00=_hpKKNWNCVpMh/2S Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit On Saturday 08 January 2011 18:41:10 Hans Petter Selasky wrote: > Hi, > > Can someone running FreeBSD 8.2-RC1 with more than one or external USB > webcam or DVB-XXX devices verify the following: > > 1) Install /usr/ports/multimedia/webcamd > > 2) Reboot > > 3) Check that character devices are created for your device(s) under /dev > > /dev/videoX for webcams > > /dev/dvb/adapterX for DVB devices > > 3) HAL should show your device. > > lshal | grep -i video > lshal | grep -i dvb > > 4) Hot replug the USB plug of your USB webcam/DVB device, perform checks > 1,2 and 3. If same result everything is OK. > Hi, After that the devd notify string was changed last year, hald stopped registering attached USB devices because the match string was too narrow. Can someone with HAL knowledge please review the attached patch for /usr/ports/sysutils/hal . My patch uses strstr() instead of strncmp(), but really a full parse with respect to " characters is required, because cdev=ugen, could appear inside some strings. When it works, lshal will show USB devices plugged after boot. --HPS --Boundary-00=_hpKKNWNCVpMh/2S Content-Type: text/x-patch; charset="ISO-8859-1"; name="hal.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="hal.patch" diff -ur hal.orig/files/patch-hald_freebsd_hf-usb2.c hal/files/patch-hald_freebsd_hf-usb2.c --- hal.orig/files/patch-hald_freebsd_hf-usb2.c 2011-01-08 19:01:54.000000000 +0100 +++ hal/files/patch-hald_freebsd_hf-usb2.c 2011-01-08 19:05:14.000000000 +0100 @@ -133,8 +133,8 @@ + (strcmp(type, "CREATE") && strcmp(type, "DESTROY"))) + return FALSE; + -+ if (! strncmp(data, "cdev=ugen", strlen("cdev=ugen")) || -+ ! strncmp(data, "cdev=usb", strlen("cdev=usb"))) ++ if ((strstr(data, "cdev=ugen") != NULL) || ++ (strstr(data, "cdev=usb") != NULL)) + return TRUE; + + return FALSE; --Boundary-00=_hpKKNWNCVpMh/2S--