Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Sep 1999 20:02:45 +0200 (CEST)
From:      wilko@freebsd.org
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   misc/13807: data-sensitivity buglet in 'make release' BUILDNAME
Message-ID:  <199909181802.UAA56245@yedi.iaf.nl>

next in thread | raw e-mail | index | archive | help

>Number:         13807
>Category:       misc
>Synopsis:       data-sensitivity buglet in 'make release' BUILDNAME
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 18 11:30:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Wilko Bulte
>Release:        FreeBSD 3.3-STABLE i386
>Organization:
tcja.nl
>Environment:

	'make release' running on 3.3-REL

>Description:

	The BUILDNAME shell variable that is fed to 'make release'
	is sensitive to the data it is set to. 'Appropriate' data
	makes the 'make release' build fail:

echo "echo make release Finished"       >> /local2/Gen/mk
chmod 755 /local2/Gen/mk
chroot /local2/Gen /mk
+ _RELTARGET=doRELEASE
+ export CFLAGS=-O -pipe
+ export DISTRIBUTIONS=bin manpages catpages games proflibs dict info doc
compat1x compat20 compat21 compat22 krb des
/mk: 6: Syntax error: "(" unexpected
*** Error code 2

>How-To-Repeat:

make release NODOC=YES NOPORTS=YES CHROOTDIR=/local2/Gen BUILDNAME="FreeBSD-3.3-release (wkb; 180999)" RELEASETAG="RELENG_3_3_RELEASE"

The offensive characters are () and most likely ; in the BUILDNAME variable

The resulting /mk file has:

export DISTRIBUTIONS="bin manpages catpages games proflibs dict info doc
compat1x compat20 compat21 compat22 krb des"
export BUILDNAME=FreeBSD-3.3-release (wkb; 180999)
export VNDEVICE=vn0

>Fix:
	
I suppose properly escaping the variable assignments while generating the
/mk file will do the trick. 

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909181802.UAA56245>