From owner-freebsd-bugs@FreeBSD.ORG  Wed Jan 26 14:10:24 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3EA4D16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 26 Jan 2005 14:10:24 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F304043D39
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 26 Jan 2005 14:10:23 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j0QEANb0074274
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 26 Jan 2005 14:10:23 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j0QEAN6k074273;
	Wed, 26 Jan 2005 14:10:23 GMT
	(envelope-from gnats)
Resent-Date: Wed, 26 Jan 2005 14:10:23 GMT
Resent-Message-Id: <200501261410.j0QEAN6k074273@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Masanori Kanaoka <kanaoka@ann.hi-ho.ne.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5EC4216A4CF
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 26 Jan 2005 14:02:21 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 47FC043D39
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 26 Jan 2005 14:02:21 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j0QE2KoM088073
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Jan 2005 14:02:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j0QE2Kfm088071;
	Wed, 26 Jan 2005 14:02:20 GMT
	(envelope-from nobody)
Message-Id: <200501261402.j0QE2Kfm088071@www.freebsd.org>
Date: Wed, 26 Jan 2005 14:02:20 GMT
From: Masanori Kanaoka <kanaoka@ann.hi-ho.ne.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: kern/76710: rgephy does not deal with status properly,if BMCR_ISO
	is set.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2005 14:10:24 -0000


>Number:         76710
>Category:       kern
>Synopsis:       rgephy does not deal with status properly,if BMCR_ISO is set.
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 26 14:10:23 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Masanori Kanaoka
>Release:        FreeBSD-current
>Organization:
>Environment:
>Description:
rgephy does not check BMCR_ISO and deal with status prperly.
>How-To-Repeat:
Code inspection.
>Fix:
--- rgephy.c.orig       2005-01-26 22:48:45.000000000 +0900
+++ rgephy.c    2005-01-26 22:49:49.000000000 +0900
@@ -342,6 +342,12 @@
 
        bmcr = PHY_READ(sc, RGEPHY_MII_BMCR);
 
+       if (bmcr & BMCR_ISO) {
+               mii->mii_media_active |= IFM_NONE;
+               mii->mii_media_status = 0;
+               return;
+       }
+
        if (bmcr & RGEPHY_BMCR_LOOP)
                mii->mii_media_active |= IFM_LOOP;
 

>Release-Note:
>Audit-Trail:
>Unformatted: