Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Aug 2024 05:58:47 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 280967] mail/dovecot: Silence warnings from rc script if dovecot_enable != YES
Message-ID:  <bug-280967-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280967

            Bug ID: 280967
           Summary: mail/dovecot: Silence warnings from rc script if
                    dovecot_enable !=3D YES
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ler@FreeBSD.org
          Reporter: john@jmarshall.id.au
          Assignee: ler@FreeBSD.org
             Flags: maintainer-feedback?(ler@FreeBSD.org)

Created attachment 252976
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D252976&action=
=3Dedit
[PATCH] Silence rc script warning unless dovecot_enable =3D YES

If the dovecot rc script cannot find a dovecot configuration file, it will
complain - even if there are no dovecot_* variables defined in rc.conf (or
friends).

----------------
rwsrv08# service dovecot rcvar
=3D=3DError=3D=3D
Config file /local/etc/dovecot/dovecot.conf does not exist. If this is
a new installation, please create the config files as outlined in
        # pkg info -D dovecot
# dovecot
#
dovecot_enable=3D"NO"
#   (default: "")
----------------

I don't see the point of complaining loudly about a missing configuration f=
ile
unless the user is trying to start the product.

The attached patch skips emitting the missing file warning unless:
 - dovecot_enable =3D YES; or
 - $1 =3D onestart.

[I build dovecot on the base system, package it, and install that package i=
n a
jail. I don't have it configured to run on the base system. It irritates me
seeing that warning message whenever I boot the base system.]

WITH PATCH APPLIED
------------------
rwsrv08# service dovecot rcvar
# dovecot
#
dovecot_enable=3D"NO"
#   (default: "")

rwsrv08#=20
rwsrv08#=20
rwsrv08# service dovecot onestart
=3D=3DError=3D=3D
Config file /local/etc/dovecot/dovecot.conf does not exist. If this is
a new installation, please create the config files as outlined in
        # pkg info -D dovecot
/usr/local/etc/rc.d/dovecot: WARNING: /local/etc/dovecot/dovecot.conf is not
readable.
/usr/local/etc/rc.d/dovecot: WARNING: failed precmd routine for dovecot
rwsrv08#=20
------------------

Thank you for maintaining this port.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280967-7788>