From owner-cvs-src@FreeBSD.ORG  Wed Sep 15 23:45:03 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 498DA16A4CE; Wed, 15 Sep 2004 23:45:03 +0000 (GMT)
Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 208AA43D5E; Wed, 15 Sep 2004 23:45:03 +0000 (GMT)
	(envelope-from julian@elischer.org)
Received: from elischer.org (julian.vicor-nb.com [208.206.78.97])
	by mail.vicor-nb.com (Postfix) with ESMTP
	id F39327A3D2; Wed, 15 Sep 2004 16:45:02 -0700 (PDT)
Message-ID: <4148D3FE.5060508@elischer.org>
Date: Wed, 15 Sep 2004 16:45:02 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516
X-Accept-Language: en, hu
MIME-Version: 1.0
To: Brian Fundakowski Feldman <green@FreeBSD.org>
References: <200409152326.i8FNQnOV009184@repoman.freebsd.org>
	<20040915233915.GI36708@green.homeunix.org>
In-Reply-To: <20040915233915.GI36708@green.homeunix.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Julian Elischer <julian@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 gdb_machdep.csrc/sys/i386/include
 db_machdep.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Sep 2004 23:45:03 -0000

feel free if it's a bug..
I only committed the patch that fixes my problem ;-)

does it do the same thing?


Brian Fundakowski Feldman wrote:

>On Wed, Sep 15, 2004 at 11:26:49PM +0000, Julian Elischer wrote:
>  
>
>>julian      2004-09-15 23:26:49 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/i386/i386        gdb_machdep.c 
>>    sys/i386/include     db_machdep.h 
>>  Log:
>>  Fix breakpoint handling for i386.
>>          not sure yet about 5.x... MFC if needed.
>>  Also fixes small problems with examining some registers and
>>  some specific gdb transfer problems.
>>  
>>          As the patch says:
>>          This is not a pretty patch and only meant as a temporary
>>          fix until a better solution is committed.
>>  
>>  PR:             i386/71715
>>  Submitted by:   Stephan Uphoff <ups@tree.com>
>>  MFC after:      1 week
>>    
>>
>
>What about this change I'm still using with KDB so that break points
>don't crash my system as immediately?
>
>--- include/db_machdep.h	10 Jul 2004 23:47:19 -0000	1.18
>+++ include/db_machdep.h	27 Aug 2004 23:14:12 -0000
>@@ -35,7 +35,7 @@
> typedef	vm_offset_t	db_addr_t;	/* address - unsigned */
> typedef	int		db_expr_t;	/* expression - signed */
> 
>-#define	PC_REGS()	((db_addr_t)kdb_thrctx->pcb_eip)
>+#define	PC_REGS()	((db_addr_t)kdb_frame->tf_eip)
> 
> #define	BKPT_INST	0xcc		/* breakpoint instruction */
> #define	BKPT_SIZE	(1)		/* size of breakpoint inst */
>
>  
>