Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Apr 2017 20:21:05 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r317464 - in head/sys: netinet netinet6
Message-ID:  <201704262021.v3QKL5fV053038@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tuexen
Date: Wed Apr 26 20:21:05 2017
New Revision: 317464
URL: https://svnweb.freebsd.org/changeset/base/317464

Log:
  Fix an issue with MTU calculation if an ICMP messaeg is received
  for an SCTP/UDP packet.
  
  MFC after:	1 week

Modified:
  head/sys/netinet/sctp_usrreq.c
  head/sys/netinet6/sctp6_usrreq.c

Modified: head/sys/netinet/sctp_usrreq.c
==============================================================================
--- head/sys/netinet/sctp_usrreq.c	Wed Apr 26 19:51:10 2017	(r317463)
+++ head/sys/netinet/sctp_usrreq.c	Wed Apr 26 20:21:05 2017	(r317464)
@@ -220,11 +220,11 @@ sctp_notify(struct sctp_inpcb *inp,
 			timer_stopped = 0;
 		}
 		/* Update the path MTU. */
+		if (net->port) {
+			next_mtu -= sizeof(struct udphdr);
+		}
 		if (net->mtu > next_mtu) {
 			net->mtu = next_mtu;
-			if (net->port) {
-				net->mtu -= sizeof(struct udphdr);
-			}
 		}
 		/* Update the association MTU */
 		if (stcb->asoc.smallest_mtu > next_mtu) {

Modified: head/sys/netinet6/sctp6_usrreq.c
==============================================================================
--- head/sys/netinet6/sctp6_usrreq.c	Wed Apr 26 19:51:10 2017	(r317463)
+++ head/sys/netinet6/sctp6_usrreq.c	Wed Apr 26 20:21:05 2017	(r317464)
@@ -237,11 +237,11 @@ sctp6_notify(struct sctp_inpcb *inp,
 			timer_stopped = 0;
 		}
 		/* Update the path MTU. */
+		if (net->port) {
+			next_mtu -= sizeof(struct udphdr);
+		}
 		if (net->mtu > next_mtu) {
 			net->mtu = next_mtu;
-			if (net->port) {
-				net->mtu -= sizeof(struct udphdr);
-			}
 		}
 		/* Update the association MTU */
 		if (stcb->asoc.smallest_mtu > next_mtu) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704262021.v3QKL5fV053038>