From owner-freebsd-stable Wed Apr 18 11:16: 4 2001 Delivered-To: freebsd-stable@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [209.152.133.57]) by hub.freebsd.org (Postfix) with ESMTP id 33B7237B423; Wed, 18 Apr 2001 11:15:58 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.3/8.11.1) id f3IIFRt22674; Wed, 18 Apr 2001 11:15:27 -0700 (PDT) (envelope-from obrien) Date: Wed, 18 Apr 2001 11:15:25 -0700 From: "David O'Brien" To: Jordan Hubbard Cc: freebsd-stable@FreeBSD.ORG, phk@FreeBSD.ORG, nicholas harteau , netch@netch.kiev.ua Subject: Re: Fw: fresh 4.3-RC: "microuptime went backwards", console lockup Message-ID: <20010418111525.B22207@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <20010418091425L.jkh@osd.bsdi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010418091425L.jkh@osd.bsdi.com>; from jkh@osd.bsdi.com on Wed, Apr 18, 2001 at 09:14:25AM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Apr 18, 2001 at 09:14:25AM -0700, Jordan Hubbard wrote: > Erm, I'd really like your opinion on this. The guy is feeling > naturally somewhat slighted. Very sorry about missing this. > MFC: > Convert all users of fldoff() to offsetof(). fldoff() is bad > because it only takes a struct tag which makes it impossible to > use unions, typedefs etc. ... > === cut === > --- src/sys/i386/isa/clock.c 2000/08/03 00:09:29 1.149.2.1 > +++ src/sys/i386/isa/clock.c 2001/03/05 13:09:01 1.149.2.2 > [...skipped by netch...] > @@ -191,7 +191,7 @@ SYSCTL_OPAQUE(_debug, OID_AUTO, tsc_time > static struct timecounter i8254_timecounter = { > i8254_get_timecount, /* get_timecount */ > 0, /* no poll_pps */ > - ~0u, /* counter_mask */ > + 0x1ffff, /* counter_mask */ > 0, /* frequency */ > "i8254" /* name */ > }; > === end cut === > > and contains no more, hence commit description is _totally bogus_. The commit message is the same as the clock.c rev 1.162 change which was part of PHK's commit I was MFC'ing (I was using a script to pipe commit emails thru to produce the diffs). I do not know if this change in the original commit by PHK was an accident, or somewhere else in the system something is different from RELENG_4 such that it needs a different value in the struct. Maybe PHK can comment on that part of the change. I certainly do not mind backing out clock.c rev 1.149.2.2 if you want. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message