From owner-svn-src-all@FreeBSD.ORG Tue Dec 25 11:28:24 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7D0574D3; Tue, 25 Dec 2012 11:28:24 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id EE3558FC0C; Tue, 25 Dec 2012 11:28:23 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qBPBSKKK061478; Tue, 25 Dec 2012 13:28:20 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.3 kib.kiev.ua qBPBSKKK061478 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qBPBSKek061477; Tue, 25 Dec 2012 13:28:20 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 25 Dec 2012 13:28:20 +0200 From: Konstantin Belousov To: Alfred Perlstein Subject: Re: svn commit: r244663 - stable/9 Message-ID: <20121225112820.GC53644@kib.kiev.ua> References: <201212241422.qBOEMrcF021632@svn.freebsd.org> <50D8B533.8080507@mu.org> <20121225104422.GB53644@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kJMkLA1uPhjFFA+D" Content-Disposition: inline In-Reply-To: <20121225104422.GB53644@kib.kiev.ua> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-stable@freebsd.org, Adrian Chadd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-9@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2012 11:28:24 -0000 --kJMkLA1uPhjFFA+D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 25, 2012 at 12:44:22PM +0200, Konstantin Belousov wrote: > On Mon, Dec 24, 2012 at 12:04:03PM -0800, Alfred Perlstein wrote: > > On 12/24/12 11:24 AM, Adrian Chadd wrote: > > > ... why'd we break the KBI in a stable branch? > > > > > I am not sure either. > >=20 > > I think a single VOP for nullfs (while ugly) would have sufficed. > No, it doesn't. >=20 > Even if it would be sufficient, having a switch right after the > vtable call is silly. But, ignoring the sillyness, having a single > VOP forces a filesystem, needed to override the single bit of behaviour, > to override all behaviours hidden from under the common VOP. Besides > the incovenience, it breaks the bypass. This is why I did not went > this route in the HEAD commit. >=20 > Making HEAD and stable diverge for the VOP table is unmaintainable. >=20 > At least one other change which cannot be covered by the VOP table > hacking is the struct vfsops new method. >=20 > Traditionally (my memory goes back to 6.x branch) we did not maintained > VFS KBI stability on the branches. Forgot to note, you completely ignored the VOP vnode locking protocol in your patch. --kJMkLA1uPhjFFA+D Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQ2Y3TAAoJEJDCuSvBvK1BvfUP/Rp2E+p82BtuyLbvSr3cyQ2t ICfwzPODtyhcnhbqkJPRL9zLfxBwSydeudrWdqXvcAXg1YOCHMN4ec3kOeiYkJ23 yxgITuev2qNWB1uX6YCX3SFpEYxOC7/hcnJf36dlkZ5UzgG5uU/Q80EBf3dAbYqj hSqrgx689ueg6xFMFXXL0n3Tn8rzmsIuHK1aB6Z3aiK6wHhkiebJKns6EeK/4DSV E5CPoFSYjx2oEKCV3P4aprzcWyA3Vkhs6nHYSqcEzAaZwstArbO1vGO2cJPQijV6 54XcEPptNG+1WuJWf3I0G4dnp/l9UvMRs5cs8Ro7G7K+VK8UVlw0OvSGmKCP6ASb GMBKiSzKejxeGRRWhlgzM81u05co+NlZb9BsE/g/j3wKCLqNQeOsLirNxmsHGz7E np7l19hxDWI0k/CdN8QgBPD1A6qOdnJo/SPXRgtjOIzhsd/4WyAbuKogjY1/LuHj m5QX6jftSxRAJHJ+uUy5iNe49SoOo0Rj/Tu72vyCz2jTeobCE4XrurZ91WKhJ4YG uxyu2X2qqgZd2jL66krhJ5iT41BctzFuwfQLp0CevzIvcrzX5jXzmpaTtIYqnWBG ciR3v+HoobMV6zSQF3fbdT0yAZke6Zf9+1y0F/SP7i8yjJoKDQh8Ou6MweHbzvzh EGQojKIByGl0DkcgFuoP =0MQN -----END PGP SIGNATURE----- --kJMkLA1uPhjFFA+D--