From nobody Wed Jun 4 01:51:13 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bBrCQ2GCbz5xDw3; Wed, 04 Jun 2025 01:51:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bBrCQ0dl3z3Z6W; Wed, 04 Jun 2025 01:51:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749001874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QUrlkjrjrdY9WC6tBWvHT0/TXVSH2ObfkCqtqjIMEOA=; b=WU55XPyq4Rp/dRSKKtVGZZvM8Bsz9D8JvSdBvfWFXCJrA9PSEJ5h1Y1IbsIvszHx5lfPoy gcyKLFyj68lc69aFm3IDunx9RHrbY7W/d01uLaLFHOqDHD6Zz1mDo+6zORVjZIy/lw5R0q XJyD9tBVcJe1hwrBPutZBQvKOwT8kwfem+KpuEo8K/0DGgaw8KcxIqUV6qmsRUT5iX5z/8 TZFUttgXHbo4VM2UfhkJtea4DBSCXKgCGiSYOGf5P1aWiTNFBUcwUZFoSK6/YZfJWAHkgT C1sq5QbZzH3FaHau2ZDuCi16SdU2tAzg8ISYn13O9TuruilMXLRkH+G3toixnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749001874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QUrlkjrjrdY9WC6tBWvHT0/TXVSH2ObfkCqtqjIMEOA=; b=FoTtnmZ39RPp80lt837jqhkuETwgpTu7D3XZRgtmbMR2QLlEm56JD6dSIh/ilN3fGOc9hh 7XwfXeai571Igltpwr1D+1alFzoSfPWufbEjiW4KMm50+AOJF0FuyaKI9dMs0zzrjIa5/5 NyrpD0NjtfIhQuMGDITtAtWfmpL5GTmQ7nhIaOrfEp51beKjdp7VynQ72BDFmXKoLsMh6P qOFsNuQ5XEotqF/QSp0pi2BQTcOYBVyKCLhdeA9j13e+Bj7Ve96SuFH8B0uZUKBhKQK96i +UtTOmgI6dmlucT+JxIyaVxYHENN2lYxmhq+6KIaN39SAoKPsKWtbburtrNXwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749001874; a=rsa-sha256; cv=none; b=QDpfeZxayn58OpIRQ4nGW5zpepnrob3/7/pEQLnMdLRBguPMt1G/Zmjo40XGVWB0szDVMz qGdq8JvWBj7wk1nm+SpB6d9zPW3SypEsEZ7pDOthysbUUe/9dFVejESOfnPQSaTXahMCRc wo17yyZPbvvOpAdvEf/pJFwemftpqLqHdYTYDqTGuYtTA2Q2IjofnTW7BClbA+ygPPGMrt zcgfD32PtY4S98zxyuon9iLzL1XNRRtQEJBk6RzNwl0oiBHh/t8W08mAp3NMwwB3qrko7S ql9dI6gVuo7Pomfl7lx//vbhWZejxC/9DKRlsnwKH7LDOzYfFW7OzPuvNq9atQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bBrCP6WDgz13cQ; Wed, 04 Jun 2025 01:51:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5541pDQB016445; Wed, 4 Jun 2025 01:51:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5541pDHs016442; Wed, 4 Jun 2025 01:51:13 GMT (envelope-from git) Date: Wed, 4 Jun 2025 01:51:13 GMT Message-Id: <202506040151.5541pDHs016442@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 3eb26ef41ce8 - main - kdump: nicer printing of wait*() ID arguments List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3eb26ef41ce8a1f78ae9a1236ffccd9ced89d32b Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=3eb26ef41ce8a1f78ae9a1236ffccd9ced89d32b commit 3eb26ef41ce8a1f78ae9a1236ffccd9ced89d32b Author: Kyle Evans AuthorDate: 2025-06-04 01:51:06 +0000 Commit: Kyle Evans CommitDate: 2025-06-04 01:51:06 +0000 kdump: nicer printing of wait*() ID arguments Currently, both of these will print pid/uid/gid/sid/jid in hex, which isn't very helpful for eyeballing. Align more closely with truss(1) and print these in decimal instead. `ip` is likely wider than our ID type, so we do a small casting trick in wait4(2) to get it sign-extended and rendered properly. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D50496 --- usr.bin/kdump/kdump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c index a8f3df14f304..ff32dd418f24 100644 --- a/usr.bin/kdump/kdump.c +++ b/usr.bin/kdump/kdump.c @@ -937,7 +937,8 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, narg -= 2; break; case SYS_wait4: - print_number(ip, narg, c); + *ip = (pid_t)*ip; + print_decimal_number(ip, narg, c); print_number(ip, narg, c); putchar(','); print_mask_arg0(sysdecode_wait4_options, *ip); @@ -950,7 +951,7 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, c = ','; ip++; narg--; - print_number64(first, ip, narg, c); + print_decimal_number64(first, ip, narg, c); print_number(ip, narg, c); putchar(','); print_mask_arg(sysdecode_wait6_options, *ip);