From owner-cvs-all  Wed Sep 13 17:26: 1 2000
Delivered-To: cvs-all@freebsd.org
Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [194.217.50.228])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7784E37B423; Wed, 13 Sep 2000 17:25:56 -0700 (PDT)
Received: from originative.co.uk (lobster.originative.co.uk [194.217.50.241])
	by mailgate.originative.co.uk (Postfix) with ESMTP
	id 38C3A1D147; Thu, 14 Sep 2000 01:25:55 +0100 (BST)
Message-ID: <39C01B13.2E19971@originative.co.uk>
Date: Thu, 14 Sep 2000 01:25:55 +0100
From: Paul Richards <paul@originative.co.uk>
X-Mailer: Mozilla 4.74 [en] (X11; U; Linux 2.2.12 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Peter Wemm <peter@netplex.com.au>
Cc: John Baldwin <jhb@pike.osd.bsdi.com>,
	"Steven E. Ames" <steve@virtual-voodoo.com>,
	Gregory Neil Shapiro <gshapiro@gshapiro.net>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/sendmail Makefile
References: <200009132356.e8DNuSG96781@netplex.com.au>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Peter Wemm wrote:
> 
> Paul Richards wrote:
> > John Baldwin wrote:
> > >
> >
> > > Then you could have things like:
> > >
> > > .ifdef(SENDMAIL_USE_SASL)
> > > SENDMAIL_CFLAGS+=-I/usr/local/include -DSASL
> > > ...
> > > .endif
> > >
> > > If you wanted to have shortcuts for common extensions.  You could stick
> > > these in either sendmail's Makefile or make.conf.  Probably in sendmail's
> > > Makefile though.
> >
> > More generic would be to add
> >
> > .ifdef(USE_SASL)
> > CFLAGS+=-DSASL -I/usr/local/include/sasl
> > LDADD+=-L/usr/local/lib -lsasl
> > .endif
> >
> > to the mk file so that other applications will use SASL if USE_SASL is
> > set in make.conf
> >
> > Paul Richards
> > FreeBSD Services Ltd
> 
> Except we aren't meant to be hardcoding the paths.
> eg: /opt/sasl/{include,lib}  is supposed to be supported.  The build has
> no business hardcoding /usr/local in it.  Yes, I know there are some places

True, the question is then how tied to the ports system should it be?
The following would work.

.ifdef(USE_SASL)
	CFLAGS+=-DSASL -I${LOCALBASE}/include/sasl
	LDADD+=-L${LOCALBASE}/lib -lsasl
.endif

but that requires LOCALBASE to be visible to the base build system which
currently it isn't.

Paul Richards
FreeBSD Services Ltd


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message