From owner-p4-projects@FreeBSD.ORG Wed Nov 10 17:01:52 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 26C1816A4D0; Wed, 10 Nov 2004 17:01:52 +0000 (GMT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E565B16A4CE for ; Wed, 10 Nov 2004 17:01:51 +0000 (GMT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C28943D55 for ; Wed, 10 Nov 2004 17:01:51 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.1/8.13.1) with ESMTP id iAAH1hGT046827; Wed, 10 Nov 2004 09:01:43 -0800 (PST) (envelope-from marcel@xcllnt.net) In-Reply-To: <20041110.021844.34601722.imp@bsdimp.com> References: <200411070550.iA75o8Uq060242@repoman.freebsd.org> <20041110.021844.34601722.imp@bsdimp.com> Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <323321AD-333A-11D9-81D7-000D93C47836@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Wed, 10 Nov 2004 09:01:42 -0800 To: "M. Warner Losh" X-Mailer: Apple Mail (2.619) cc: Perforce Change Reviews Subject: Re: PERFORCE change 64481 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2004 17:01:52 -0000 On Nov 10, 2004, at 1:18 AM, M. Warner Losh wrote: > : Add resource allocation and release related code. With this, > : uart(4) probes as a child of scc(4). Next, IRQ handling so > : that we can do something other than wait for the interrupt > : storm to pass over... > : > : + rle->res = malloc(sizeof(struct resource), M_SCC, > : + M_WAITOK | M_ZERO); > > We gotta find a way to put this in fewer drivers, not more... > Encoding sizeof struct resource is why you need > __RMAN_RESOURCE_VISIBLE, which generally shouldn't be defined. Agreed. I don't like it either. My first thought was to add a wrapper for the malloc and my second was that I don't want to get sidetracked right now. I'll get sidetracked for the newbus issues (the bus-specific interrupt handlers and adding a mechanism for time-multiplexing) that I still need to work out. I'll probably deal with the resource stuff then. If I can defer the newbus issues, I'll fix the resource stuff before I commit. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net