From owner-cvs-all@FreeBSD.ORG  Mon Apr 14 12:04:23 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E52EF37B404; Mon, 14 Apr 2003 12:04:23 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 633B443F75; Mon, 14 Apr 2003 12:04:22 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.8/8.12.3) with ESMTP id h3EJ4KA7053824;
	Mon, 14 Apr 2003 13:04:21 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Mon, 14 Apr 2003 13:04:06 -0600 (MDT)
Message-Id: <20030414.130406.104032537.imp@bsdimp.com>
To: mdodd@FreeBSD.ORG
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030414124016.O39446@sasami.jurai.net>
References: <200304140945.h3E9jPCe005099@repoman.freebsd.org>
	<20030414.102923.58074053.imp@bsdimp.com>
	<20030414124016.O39446@sasami.jurai.net>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: sobomax@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
cc: cvs-src@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2003 19:04:24 -0000

In message: <20030414124016.O39446@sasami.jurai.net>
            "Matthew N. Dodd" <mdodd@FreeBSD.ORG> writes:
: On Mon, 14 Apr 2003, M. Warner Losh wrote:
: > In message: <200304140945.h3E9jPCe005099@repoman.freebsd.org>
: >             Maxim Sobolev <sobomax@FreeBSD.org> writes:
: > :   Before attaching device set PCIM_CMD_PORTEN in addition to
: > :   PCIM_CMD_MEMEN and PCIM_CMD_BUSMASTEREN, becaise some braindead
: > :   BIOSes (such as one found in my vprmatrix notebook) forget
: > :   to initialize it properly resulting in attachment failure.
: >
: > Actually, code like this should be the pci bus, since all driver have
: > this issue...
: 
: Likely this could be added to the bus_alloc_resource() path...  Doing a
: sanity check on requests and then enabling the resource seems like the
: correct solution.

Yes.  That's what I had in mind.  However, the bus master stuff still
may need to be done in the drivers since I don't think that the
bus_space_dma routines go through newbus at all...

Warner